Closed (fixed)
Project:
Drupal.org content
Component:
Issue tags
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Feb 2015 at 17:31 UTC
Updated:
13 Jun 2025 at 08:49 UTC
Jump to comment: Most recent
Official tag is: API clean-up
Source: Special issue tags.
The following tags should be edited:
Comments
Comment #1
develcuy commentedthe official tag is "API clean-up": https://www.drupal.org/node/1207020
Comment #2
gisleComment #3
gisleFixed three of them.
Comment #4
gisleComment #5
avpadernoComment #6
avpadernoComment #7
avpadernoI am moving this issue as per Maintaining issue tags.
Comment #8
avpadernoComment #9
avpadernoComment #10
avpadernoCould not we start with renaming the duplicate tags as API clean-up (duplicate tag)?
Comment #11
gisleWhat is the rationale behind that?
I think it would be better to rename the duplicate tags of "API cleanup": "API clean-up".
We do not want two different tags for the same purpose, and "API clean-up (duplicate tag)" is IMHO just as redundant as, for instance, "D7 API clean-up".
Comment #12
avpadernoI asked because it has been done (not from me) for another tag.
The effect of renaming tags, on drupal.org, is getting two tags with the same name. I guess the reason for renaming that tag adding (duplicate tag) was to make clear to users which was the main/correct tag.
Comment #13
gisleOk.
OK - I can see where this is coming from.
Given that, then renaming an existing non-canonical tag is not the right thing to do.
The correct procedure is to remove the non-canonical tag (e.g. "D7 API clean-up") and the add the canonical tag ("API clean-up"). Then there will be no duplicate.
This is quite tedious, because the procedure must be repeated on every tagged node, but it will produce the desired result.
Doing a tag rename to "API clean-up (duplicate tag)" will short-circuit this, but will lose information. Not all these "cleanup" tags has anything to do with "API clean-up", so they're not duplicates of "API clean-up". A lot of them are about refactoring code, or other tasks. By renaming them "API clean-up (duplicate tag)" we misrepresent the actual meaning of the tag.
Comment #14
avpadernoIf none of the left tags is synonym of API clean-up, this task has been completed.
I think D7 API clean-up should be replaced by API clean-up, since we don't have a different tag for each Drupal version.
Then, if code cleanup and Cleanup are used for the same purpose, they could be merged. (I am not sure Cleanup is never used for something that is not code, but that is something to check.)
I agree that code cleanup is different from API clean-up. While both tags are about code, cleaning up an API means "changing the public interface of code," while code cleanup means, for example, removing unused variables.
Comment #15
avpadernoAs side note, we don't have tools to merge tags. We can rename a tag, but if two tags have the same name, they are kept separated.
Instead of merge, we can just replace one tag with another one, which means we would edit each issue.
I take that merging is not our task.
Comment #16
avpadernoComment #17
avpadernoSince the tags listed in the issue summary do no longer exists, this issue can be considered fixed.