Do not allow admins to edit the weblinks vocabulary machine name

Three images
1. before change when first visiting the form
2. before change but after clicking 'edit'
3. After patch - no 'edit' link or field shown

Patch for testing.

Thanks.

The commit above has not yet appeared in the dev release which still shows:

Last updated: March 4, 2015 - 17:18
Last packaged version: 7.x-1.0-alpha2+34-dev

This is just a reminder after the next commit to check that this change is also included.

[update: yes this commit is included now]

I've noticed that the change I made was not exactly right. I tested the 'current' vocabulary used for weblinks. This is wrong, as it allows the weblinks machine name to be editted when a different non-weblinks vocab is the one currently selected for Weblinks navigation. I think it should specifically check on the vocab called 'weblinks' ie the one provided by our module, not the one being used by the module.

The change is minimal - we simply check the existing machine name #default_value instead of matching on vid.

Here's a patch

In weblinks.install we have the function weblinks_update_7000 which looks like it should rename the field to the D7 standard.

/**
 * Rename field to 'taxonomy_weblinks'.
 */
function weblinks_update_7000() {
  $new_field_name = 'taxonomy_weblinks';
  // Test to see if the taxonomy_weblinks field exists.
  $fields = _update_7000_field_read_fields(array('field_name' => $new_field_name));
  if ($fields) {
    // Since the field exists, we're done.
    return;
  }
  // Calculate the old field name.
  $vid = variable_get('weblinks_nav_vocabulary', 0);
...

Did you run this after converting from D6 to D7?

I beg your pardon ;-) yes I thought you wrote that function - just checking that you had not forgotten it.

I think that if the vocab machine name is not 'weblinks' then we should not be preventing the rename. The only point of this patch was to retain the name 'weblinks' and if, for whatever reason, that is already no longer the case on a specific site then we should not try any further to identify the actual name. Just leave the form unprotected as it is now.

It should be possible to write another update function to rename the machine name. That would be a good solution, but are we "allowed" to rename a vocabulary machine name that is not "owned" by our module?

Which in turn means we can also prevent renaming the vocabulary machine name even the machine name is not 'weblinks'.

Yes you are right, we could do that, but I do not think it would gain us anything. The point about ensuring our vocab was called 'weblinks' was to allow for sensible defaults to work. With the patch in #10 we at least know that for a new D7 install we can rely on this default. For sites migrated from D6 our code should still work in general as we cater for non-weblinks vocabs in all places now. So I think that is enough and we do not need to inhibit renaming when the vocab is not 'weblinks' as that would probably cause more problems than it solves.

This issue will remain as an aid to help support sites if they have any difficulty with non-weblinks vocabs. The discussion above is very valuable for that.

Are you OK if I commit the change from #10 then we call this issue fixed?

Excellent. Thank you.