Remove .leaf/.menu-item--leaf from menu CSS components

Hi,

So I just have to Remove .leaf/.menu-item--leaf from menu CSS components and upload the patch.
Could you please help me in writing the example: what exactly needs to there in example?

Thanks,
Nit

I removed the .leaf reference out the MenuLinkTree.php file.
I did find a reference to .leaf class in Seven theme but I don't think removing this breaks anything.

I'm still working on the example because I noticed that the menu-tree.html.twig was removed in #1777332: Replace theme_menu_link() and menu-tree.html.twig with a single Twig template

Here is an updated patch with the leaf reference removed from the book module.

Updated the patch to remove all references from the Book module.

I'm not seeing any other references to the leaf class so that's good. We just need the example text.

I think this example should cover this.
This doesn't reproduce the old behaviour since the 'below' variable is limited to the 'maximum number of menu levels to display' we set in the menu block configuration.

In my opinion this is the right behaviour since it's not displaying any children elements.

lemme grap

Ok after playing a bit with it and getting the menu to crash on me hard, i rewrote #11 & added the only leaf class there should ever be ;)

menu.html.twig

{% import _self as menus %}

{#
  We call a macro which calls itself to render the full tree.
  @see http://twig.sensiolabs.org/doc/tags/macro.html
#}
{{ menus.menu_links(items, attributes, 0) }}

{% macro menu_links(items, attributes, menu_level) %}
  {% import _self as menus %}
  {% if items %}
    {% if menu_level == 0 %}
      <ul{{ attributes.addClass('menu') }}>
    {% else %}
      <ul class="menu">
    {% endif %}
      {% for item in items %}

          {#
            test if theres more menu items to be printed
            if there is add a class for it
          #}
          {% if item.below|length == 0 %}
            <li{{ item.attributes.addClass('im-like-a-leaf-on-the-wind') }}>
          {% else %}
            <li{{ item.attributes }}>
          {% endif %}

          {# print out the link & test if theres more items #}
          {{ link(item.title, item.url) }}
          {% if item.below %}
            {{ menus.menu_links(item.below, attributes, menu_level + 1) }}
          {% endif %}
        </li>
      {% endfor %}
    </ul>
  {% endif %}
{% endmacro %}

This is a screenshot from d8 right now without the menu cleanup & this patch to remove the .leaf that are flying around (see what i did there ... )

ungraps + bonus points for knowing where the leaf reference is coming from

Maybe a change record or add the sample text to this issue summary and then add a line here? https://www.drupal.org/node/2356951

I'm getting the reference @mortendk
Isn't it the scene from Serenity where Hoban 'Wash' get's killed?

@pjbart ! yes +1 in epic geek points ;)

Write an example to add this back in through either in a menu-tree.html.twig template override or preprocess.

Let's put this in a CR then...

Sorry I'm going to be a pain in the ... can we merge the CR for #2422363: Rewrite the menu CSS components inline with our CSS standards with CR for this one? Less CRs is a good thing and these are on the same topic.

I merged the CRs.

With the changes in #2422363: Rewrite the menu CSS components inline with our CSS standards isn't a leaf also...

.menu-item:not(.menu-item--expanded):not(.menu-item--collapsed)


Let's publish the CR after the other issue goes in.

CSS and templates are not frozen in beta. Committed 9e21230 and pushed to 8.0.x. Thanks!