Follow-up to #2422341: seven appearance-page.css css cleanup

Problem/Motivation

In Sevens's appearance page CSS:

.system-themes-list__header {
  font-weight: normal;
  text-transform: uppercase;
}

Changing headers to look different on different pages encourages inconsistency, we should not override header stying per page, and use the reuseable header classes to change the styling of headers where appropriate: #2028053: Add typographic styles, components, and utility classes

Proposed resolution

Remove the styling completely

Remaining tasks

* Delete the file, and remove it from any yml files and tests

User interface changes

A small change to the headings on the appearance page.

API changes

none

CommentFileSizeAuthor
#2 Screen Shot 2015-02-11 at 14.28.18.jpg420.01 KBlewisnyman
#2 Screen Shot 2015-02-11 at 14.26.49.jpg420.76 KBlewisnyman
#1 remove_seven_s-2423577-1.patch777 bytesjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
Issue tags: +Needs screenshots
StatusFileSize
new remove_seven_s-2423577-1.patch777 bytes
lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2015-02-11 at 14.26.49.jpg420.76 KB
new Screen Shot 2015-02-11 at 14.28.18.jpg420.01 KB

Thanks! Here are some screenshots:

Before:

After:

cosmicdreams’s picture

cosmicdreams commented

The button that allowed you to toggle between a vertical menu and a horizontal menu seems to disappear. (see the left menu) That seems to be an unintended change.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Huh, weird they are not related at all but I've seen that on cache clears.

Lewis can you confirm refresh should fix that.

Nice catch

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

Back to NR to check that. Good eyes.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

That looks like a regression unrelated to this issue. Seems like JS because it's there but style="display: none;" on it.

Back to RTBC:) I'll hunt down the issue that caused that.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Caused by this commit (git bisect)
dbb32f2e18d3b1b79bbe50335ca93da8ea9ed382 is the first bad commit

Author: Alex Pott <alex.a.pott@googlemail.com>
Date:   Wed Feb 11 16:12:46 2015 +0000

    Issue #2260061 by Jelle_S, attiks, Wim Leers, mdrummond, mgifford, holist: Responsive image module does not support sizes/picture polyfill 2.2

#2260061: Responsive image module does not support sizes/picture polyfill 2.2

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented

Opened #2424805: Toolbar can no longer switch horizontal and vertical -- expects breakpoints ordered from smallest to largest; responsive images need largest to smallest to address the toolbar regression.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Good sleuthing! Also I always love less code. :)

Committed and pushed to 8.0.x. Thanks!

  • webchick committed cab6a8c on 8.0.x 
    Issue #2423577 by LewisNyman, joelpittet: Remove Seven's appearance-page...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.