Love this module! Thank you!!!
My users will be confused with this setting "Keep?" and they certainly wont take the time to read my full accurate description of what it's for. I'm using very little from this module...just "view" on a basic content type for individual users. I really only need "View" checkbox and want it to be simple, like: Checked > "Save Grants" = Saved grants for user. Unchecked > "Save Grants" = User disappears from list. Anyway, what's a simple concise explanation of "Keep?"?
Some testing for my use case: I have two users. UserA i checked "View" and unchecked "keep." UserB unchecked "View" and kept "keep". After save grants they both disappeared and both lost their permissions. It seems that no matter what both "keep" and "view" must be checked together. It's somewhat remarkable that this module is perfect in every way for my use case, but this "keep" thing will cause problems.
Comments
Comment #1
System Lord CreditAttribution: System Lord commentedComment #2
beetlecat CreditAttribution: beetlecat commentedWould unchecking the "keep" box and hitting save simply flush all (3?) possible flags? Seems like a shortcut for no reason at that point.
Comment #3
System Lord CreditAttribution: System Lord commentedI'd like to reiterate..."Keep" doesn't make sense. It doesn't seem to serve any purpose other than to confuse. I'd like to hear of a use case where "keep?" suits them, works, or does anything?
Comment #4
caspervoogt CreditAttribution: caspervoogt at Plethora commentedI must say I agree. I know there must be good reasons for the way it is, but I am coming at this from having to hand this over to a client, and having to explain what this checkbox is.
I have read some of the explanations for it, but explaining this to a client is troublesome. Seems to me "Keep" should be assumed, and if we wanted to "remove" or "delete" then that should be a separate, discrete action. That would be clearer and easier to explain.
Comment #5
jduhls CreditAttribution: jduhls commentedagreed: "Keep?" is strange. Module needs some UI/UX work. If you uncheck it then click "save grants", it removes the user from grants.
Comment #6
MrPaulDriver CreditAttribution: MrPaulDriver commentedI need to chime in here and say that Keep? is totally ambiguous and having read the posts from others asking what is Keep? I am still none the wiser.
Apart from the maintainers, does anybody actually know the answer?
Comment #7
tkogias CreditAttribution: tkogias commentedI ended up here, trying to see why nodeAccess doesn't work in my case. I want to provide edit access for nodes to specific users.
The problem I have is that this 'Keep?' checkbox is nowhere to be found for me. Although I do see the message, and I googled that message cause I want to see whether this is why nodeAccess doesn't work as intended (whatever I try, selected users put in the autocomplete and given grants, do NOT have edit access).
Any help?
I use D8, and 8.x-1.0-beta2 version of module.
---
EDIT - I did find it, I never pressed 'search' before, because I always typed in my test-user and clicked on the auto-completed name. It is not straight-forward that you *should* click search before all checkboxes appear. I leave my comment here in order someone else has the same problem in the future and ends up here. However, I would suggest that for user experience, it shouldn't be this way, check boxes should be there already, and if it's not possible, at least inform the user that he should click search, even if searching for the username is not necessary.
Comment #8
MrPaulDriver CreditAttribution: MrPaulDriver commentedI initially made the same mistake myself. Perhaps the search button would make more sense if labelled 'Confirm Selection' or something similar.
As far as Keep? is concerned, and given that it is enabled by default, I have chosen to hide it with css. Not ideal by any means, but it seems to be working for my use case.
The css was not straight-forward as the module has not been written with theming in mind, so I had to use nth-child selectors to target the second cell of the table header and each row.
Comment #9
caspervoogt CreditAttribution: caspervoogt commentedThe problem I have with Keep is that the UI makes it look like "Keep" is a permission, like "view", "edit", or "delete". As far as I know it isn't. But I don't really know what it even means or does. All I know is to always leave it checked except when you need to delete a grant. It's even more confusing given that there is a checkbox called "Delete", so it is possible to check both "Keep" and "Delete". That's just confusing.
Comment #10
jadhavdevendra CreditAttribution: jadhavdevendra as a volunteer commentedOn Drupal 7 I also see that if I un-check the keep checkbox and click on save grants, nothing happens. On page refresh the checkbox reverts to checked state. Weird behavior. I prefer to hide the checkboxs using CSS as it is of no use.
Comment #11
jungle2.0.x is the latest dev branch.
Comment #12
jungleSo let's end up here after 4 years without a new comment. Agree to improve the UI, but not in this issue.