Problem/Motivation

1. The page title "Configure selection language negotiation" does not make sense.
2. The "Browser language detection configuration" title is not consistent with the titles of the rest of the screens.
3. The technical word "negotiation" is avoided on the user interface, the tab is called "Detection and selection" and the negotiation methods are called "detection methods" on the UI.

Proposed resolution

1. Most pages already use "Detection" instead of "Negotiation", fix the remaining strings.
2. Unify the page titles of detection method configuration pages, especially fix the selected language method's screen.

Remaining tasks

Commit.

User interface changes

Negotiation is not mentioned on the UI anymore. Configuration page titles are fixed.

API changes

None.

Comments

balagan’s picture

StatusFileSize
new584 bytes

Title is changed to "Configure language selection negotiation" in enclosed patch.

balagan’s picture

Assigned: balagan » Unassigned
Status: Active » Needs review
balagan’s picture

Assigned: Unassigned » balagan
Status: Needs review » Needs work
balagan’s picture

StatusFileSize
new583 bytes

Taking a deeper look into the corresponding .yml file, I think it should be 'Configure selected language negotiation'.
This way all the titles would be in line:
'Configure URL language negotiation'
'Configure session language negotiation'
'Configure selected language negotiation'
'Browser language detection configuration'

balagan’s picture

Assigned: balagan » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
gábor hojtsy’s picture

Status: Needs review » Needs work
Issue tags: +D8MI, +language-base, +sprint, +Usability

The negotiation method is named "Selected language" that is what you configure. Configure language selection negotiation does not make any sense to me. You do not configure how negotiation selects language here. You configure the "Selected language" negotiation method. Let's see what other pages use:

URL => Configure URL language negotiation
Session => Configure session language negotiation
Browser => Browser language detection configuration
Selected language => Configure selection language negotiation

To establish a pattern looks like we should do "Configure selected language negotiation" which is not very clear either. (Still better than Configure selection language negotiation). If we don't want to follow a pattern (browsers don't do that either), we can use something like "Configure selected language" or something along those lines. It would be important to make it clear that you select the language for this method, not for the negotiation in general.

balagan’s picture

Issue summary: View changes
balagan’s picture

Status: Needs work » Needs review
balagan’s picture

You are right, 'Browser language detection configuration' is not in line with the other titles. I think that is also incorrect, since we are not configuring the language detection in the browser, but the language selection based on browser language. That could be also changed to ''Configure browser language negotiation' to be in line.

gábor hojtsy’s picture

Yeah "Configure browser language negotiation" sounds fine.

balagan’s picture

StatusFileSize
new580 bytes

Hold on... another patch is coming, I missed the previous change

balagan’s picture

StatusFileSize
new934 bytes

And finally I hope to get it right.

gábor hojtsy’s picture

Title: Page title "Configure selection language negotiation" is incorrectly phrased » Language negotiation configuration page titles inconsistent, incorrect
Issue summary: View changes

Retitled. Updated issue summary.

gábor hojtsy’s picture

What if we move the "Configure" to the end as "configuration" in all titles and use detection instead of negotiation to conform to the labels on the UI?

Configure URL language negotiation URL language detection configuration
Configure session language negotiation Session language detection configuration
Browser language detection configuration Browser language detection configuration
Configure selection language negotiation Selected language configuration (no need to mention detection because its explicitly selected)

A problem with negotiation (apart of the technical term) is that it indicates a dialogue is going on (Negotiation is a dialogue between two or more people or parties intended to reach an understanding from wikipedia). While on the HTTP level, this process is called negotiation, and we do consider values received in the request (URL, session, browser), but we don't ask back :) So while the proper technical term is negotiation, the more familiar detection or selection terms that are used on the tab make more sense for the site user IMHO.

balagan’s picture

I think it is a good idea to omit the word negotiation. Now looking at all the language detection and selection pages I have noticed the caption on the main page: "User interface text language detection". I think this is also incorrect, we do not detect the user interface text language, but we specify it based on the language providers. I think in this case the word "negotiation" could be used, as https://www.drupal.org/node/1497272 here negotiation is defined as the order of processing the language providers. So it would be "User interface text language negotiation". Hmm?

gábor hojtsy’s picture

Well, so the overview UI calls these detection methods, see Enable !title language detection method and Weight for !title language detection method which are the invisible titles for the checkbox and weight selection. So if we want to unify on those grounds:

Configure URL language negotiation URL language detection method configuration
Configure session language negotiation Session language detection method configuration
Browser language detection configuration Browser language detection method configuration
Configure selection language negotiation Selected language method configuration (no need to mention detection because its explicitly selected)

(Method bolded just for sake of easy recognition). I don't think we should embark on a total terminology shift here.

balagan’s picture

StatusFileSize
new1.21 KB

I have created a patch sticking to the proposal in #14.

balagan’s picture

StatusFileSize
new1.22 KB

I still missed a word... (configuration)

gábor hojtsy’s picture

Definitely better than before. I think we need to look around a bit in help text and other references to see if there are other mentions of negotiation especially in relation to these,

gábor hojtsy’s picture

@balagan: wanna continue looking at this one?

gábor hojtsy’s picture

Status: Needs review » Needs work
balagan’s picture

Assigned: Unassigned » balagan
balagan’s picture

StatusFileSize
new3.44 KB

I have found 1 more occurrence of negotiation in UI text.

balagan’s picture

Assigned: balagan » Unassigned
Status: Needs work » Needs review
gábor hojtsy’s picture

Status: Needs review » Needs work

I think there is at least one more I found with grep:

core/modules/language/src/Form/NegotiationConfigureForm.php:    drupal_set_message($this->t('Language negotiation configuration saved.'));
core/modules/user/src/Tests/UserLanguageCreationTest.php:    $this->assertText(t('Language negotiation configuration saved.'), 'Set language negotiation.')
balagan’s picture

StatusFileSize
new5.12 KB

I have found one more.

balagan’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 26: incorrect-wording-2422685-26.patch, failed testing.

balagan’s picture

StatusFileSize
new6.69 KB

Hopefully fixed the corresponding tests.

balagan’s picture

Status: Needs work » Needs review
gábor hojtsy’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Yay, looks good to me. Updated issue summary.

gábor hojtsy’s picture

Title: Language negotiation configuration page titles inconsistent, incorrect » Language negotiation configuration page titles inconsistent, should not even mention "negotiation"
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

UI strings are not yet frozen. Committed d8aa1a8 and pushed to 8.0.x. Thanks!

  • alexpott committed d8aa1a8 on 8.0.x
    Issue #2422685 by balagan: Language negotiation configuration page...
gábor hojtsy’s picture

Issue tags: -sprint

Superb, thanks @balagan, @alexpott!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.