Problem/Motivation
1. The page title "Configure selection language negotiation" does not make sense.
2. The "Browser language detection configuration" title is not consistent with the titles of the rest of the screens.
3. The technical word "negotiation" is avoided on the user interface, the tab is called "Detection and selection" and the negotiation methods are called "detection methods" on the UI.
Proposed resolution
1. Most pages already use "Detection" instead of "Negotiation", fix the remaining strings.
2. Unify the page titles of detection method configuration pages, especially fix the selected language method's screen.
Remaining tasks
Commit.
User interface changes
Negotiation is not mentioned on the UI anymore. Configuration page titles are fixed.
API changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #29 | incorrect-wording-2422685-29.patch | 6.69 KB | balagan |
| #26 | incorrect-wording-2422685-26.patch | 5.12 KB | balagan |
| #23 | incorrect-wording-2422685-23.patch | 3.44 KB | balagan |
| #18 | incorrect-wording-2422685-18.patch | 1.22 KB | balagan |
| #17 | incorrect-wording-2422685-17.patch | 1.21 KB | balagan |
Comments
Comment #1
balagan commentedTitle is changed to "Configure language selection negotiation" in enclosed patch.
Comment #2
balagan commentedComment #3
balagan commentedComment #4
balagan commentedTaking a deeper look into the corresponding .yml file, I think it should be 'Configure selected language negotiation'.
This way all the titles would be in line:
'Configure URL language negotiation'
'Configure session language negotiation'
'Configure selected language negotiation'
'Browser language detection configuration'
Comment #5
balagan commentedComment #6
gábor hojtsyThe negotiation method is named "Selected language" that is what you configure. Configure language selection negotiation does not make any sense to me. You do not configure how negotiation selects language here. You configure the "Selected language" negotiation method. Let's see what other pages use:
To establish a pattern looks like we should do "Configure selected language negotiation" which is not very clear either. (Still better than Configure selection language negotiation). If we don't want to follow a pattern (browsers don't do that either), we can use something like "Configure selected language" or something along those lines. It would be important to make it clear that you select the language for this method, not for the negotiation in general.
Comment #7
balagan commentedComment #8
balagan commentedComment #9
balagan commentedYou are right, 'Browser language detection configuration' is not in line with the other titles. I think that is also incorrect, since we are not configuring the language detection in the browser, but the language selection based on browser language. That could be also changed to ''Configure browser language negotiation' to be in line.
Comment #10
gábor hojtsyYeah "Configure browser language negotiation" sounds fine.
Comment #11
balagan commentedHold on... another patch is coming, I missed the previous change
Comment #12
balagan commentedAnd finally I hope to get it right.
Comment #13
gábor hojtsyRetitled. Updated issue summary.
Comment #14
gábor hojtsyWhat if we move the "Configure" to the end as "configuration" in all titles and use detection instead of negotiation to conform to the labels on the UI?
A problem with negotiation (apart of the technical term) is that it indicates a dialogue is going on (Negotiation is a dialogue between two or more people or parties intended to reach an understanding from wikipedia). While on the HTTP level, this process is called negotiation, and we do consider values received in the request (URL, session, browser), but we don't ask back :) So while the proper technical term is negotiation, the more familiar detection or selection terms that are used on the tab make more sense for the site user IMHO.
Comment #15
balagan commentedI think it is a good idea to omit the word negotiation. Now looking at all the language detection and selection pages I have noticed the caption on the main page: "User interface text language detection". I think this is also incorrect, we do not detect the user interface text language, but we specify it based on the language providers. I think in this case the word "negotiation" could be used, as https://www.drupal.org/node/1497272 here negotiation is defined as the order of processing the language providers. So it would be "User interface text language negotiation". Hmm?
Comment #16
gábor hojtsyWell, so the overview UI calls these detection methods, see Enable !title language detection method and Weight for !title language detection method which are the invisible titles for the checkbox and weight selection. So if we want to unify on those grounds:
(Method bolded just for sake of easy recognition). I don't think we should embark on a total terminology shift here.
Comment #17
balagan commentedI have created a patch sticking to the proposal in #14.
Comment #18
balagan commentedI still missed a word... (configuration)
Comment #19
gábor hojtsyDefinitely better than before. I think we need to look around a bit in help text and other references to see if there are other mentions of negotiation especially in relation to these,
Comment #20
gábor hojtsy@balagan: wanna continue looking at this one?
Comment #21
gábor hojtsyComment #22
balagan commentedComment #23
balagan commentedI have found 1 more occurrence of negotiation in UI text.
Comment #24
balagan commentedComment #25
gábor hojtsyI think there is at least one more I found with grep:
Comment #26
balagan commentedI have found one more.
Comment #27
balagan commentedComment #29
balagan commentedHopefully fixed the corresponding tests.
Comment #30
balagan commentedComment #31
gábor hojtsyYay, looks good to me. Updated issue summary.
Comment #32
gábor hojtsyComment #33
alexpottUI strings are not yet frozen. Committed d8aa1a8 and pushed to 8.0.x. Thanks!
Comment #35
gábor hojtsySuperb, thanks @balagan, @alexpott!