Problem/Motivation

fix the id selectors for css lint

Proposed resolution

#block-node-recent should be .block .view-content-recent

Remaining tasks

User interface changes

API changes

Comments

joelpittet’s picture

Issue tags: +Needs screenshots

This looks great to me, needs screenshots before and after but otherwise +1 :)

mortendk’s picture

StatusFileSize
new45.7 KB
new46.75 KB

Now it gets fun
When blocks id's was removed the css for seven didnt get updated to match the selectors :/
(#block-node-recent table fx)
pre patch:

post patch:

mortendk’s picture

Issue tags: -Needs screenshots

screens added

mortendk’s picture

Assigned: Unassigned » mortendk

@lewis can you look at this :)

mortendk’s picture

Assigned: mortendk » Unassigned
joelpittet’s picture

That ID doesn't exist anymore, I'd say those can be deleted, but if they are to be kept you can remove the .block prefix'd selector.

2¢

lewisnyman’s picture

Title: seven recent block css lint fix » Remove Seven's block-recent-content.css

I had a look over this CSS for this block and the changes are really subtle, I don't see how this block is being used in the admin interface anymore now that we don't have the dashboard module in core. The design tweaks that this file makes don't seem to be worth their maintenance, we should reuse some of the admin components we already have instead of add small overrides like this, but let's wait until we understand the use case of this block.

lewisnyman’s picture

Status: Needs review » Needs work
MKorostoff’s picture

LewisNyman, could you elaborate a bit on what you mean there? When you say 'reuse some admin components' what do you mean?

lewisnyman’s picture

Issue tags: -Seven

@MKorostoff Sorry I meant let's just reuse the default styling instead of overriding it. Let's remove this CSS file.

lewisnyman’s picture

Status: Needs work » Needs review
Issue tags:
StatusFileSize
new1.02 KB

Here's the patch

katzilla’s picture

Patch #11 didn't apply to latest head - added a new patch to fix

akalata’s picture

Adding #12 without the .txt at the end for testbot (@katzilla, see note on the file upload field: "Only files ending in .patch or .diff will be sent for testing.").

katzilla’s picture

@akalata - thanks for the hint. Didn't recognize it was wrong, just wondering why the bot didn't run.

Karmen’s picture

Status: Needs review » Reviewed & tested by the community

#12 (#13 really) works for me.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Yay, less code!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 86a39ef on
    Issue #2422369 by mortendk, LewisNyman, akalata, katzilla: Remove Seven'...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.