Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
Seven theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Feb 2015 at 14:59 UTC
Updated:
29 Apr 2015 at 17:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
joelpittetThis looks great to me, needs screenshots before and after but otherwise +1 :)
Comment #2
mortendk commentedNow it gets fun


When blocks id's was removed the css for seven didnt get updated to match the selectors :/
(#block-node-recent table fx)
pre patch:
post patch:
Comment #3
mortendk commentedscreens added
Comment #4
mortendk commented@lewis can you look at this :)
Comment #5
mortendk commentedComment #6
joelpittetThat ID doesn't exist anymore, I'd say those can be deleted, but if they are to be kept you can remove the .block prefix'd selector.
2¢
Comment #7
lewisnymanI had a look over this CSS for this block and the changes are really subtle, I don't see how this block is being used in the admin interface anymore now that we don't have the dashboard module in core. The design tweaks that this file makes don't seem to be worth their maintenance, we should reuse some of the admin components we already have instead of add small overrides like this, but let's wait until we understand the use case of this block.
Comment #8
lewisnymanComment #9
MKorostoff commentedLewisNyman, could you elaborate a bit on what you mean there? When you say 'reuse some admin components' what do you mean?
Comment #10
lewisnyman@MKorostoff Sorry I meant let's just reuse the default styling instead of overriding it. Let's remove this CSS file.
Comment #11
lewisnymanHere's the patch
Comment #12
katzillaPatch #11 didn't apply to latest head - added a new patch to fix
Comment #13
akalata commentedAdding #12 without the .txt at the end for testbot (@katzilla, see note on the file upload field: "Only files ending in .patch or .diff will be sent for testing.").
Comment #14
katzilla@akalata - thanks for the hint. Didn't recognize it was wrong, just wondering why the bot didn't run.
Comment #15
Karmen commented#12 (#13 really) works for me.
Comment #16
webchickYay, less code!
Committed and pushed to 8.0.x. Thanks!