Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We don't need it.
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff-2421461-4-6.txt | 515 bytes | ModernMantra |
#6 | field_type-2421461-6.patch | 3.98 KB | ModernMantra |
#4 | interdiff-2421461-2-4.txt | 2.26 KB | ModernMantra |
#4 | field_type-2421461-4.patch | 3.47 KB | ModernMantra |
#2 | interdiff-2421461-1-2.txt | 932 bytes | ModernMantra |
Comments
Comment #1
ModernMantra CreditAttribution: ModernMantra at MD Systems GmbH for MD Systems GmbH commentedSmall progress and new starting point :). Need to work on this in way to provide update config function.
Comment #2
ModernMantra CreditAttribution: ModernMantra at MD Systems GmbH for MD Systems GmbH commentedCreated update config function. Tried with update database update function but did not succeed and could not provide useful patch for that (will need some instructions about that)
Comment #4
ModernMantra CreditAttribution: ModernMantra at MD Systems GmbH for MD Systems GmbH commentedMade some progress, thanks to @berdir and his instructions and tutorial. Currently after debugging and running update function i got an error
ALTER TABLE {node__simplenews_issue} CHANGE `simplenews_issue_subscribers` `` DEFAULT NULL;
. Still a little more work on this, but i think this patch will be good starting point IMHO :-)Comment #6
ModernMantra CreditAttribution: ModernMantra at MD Systems GmbH for MD Systems GmbH commentedSmall fix, hope test should pass now...
Comment #10
ModernMantra CreditAttribution: ModernMantra at MD Systems GmbH for MD Systems GmbH commentedSetting to needs review, re-ran multiple times the test on local machine with applied path and there is no single failure. Seems random test fails...
Comment #11
miro_dietikerIt seems we have a random fail here:
So it seems that there is a random fail if the newsletter random string contains HTML brackets lt, gt. Let's investigate in a follow-up. To start, change testSendNowCron() line 281 to the value above and reproduce the bug.
Comment #13
AdamPS CreditAttribution: AdamPS at AlbanyWeb commentedComment #14
AdamPS CreditAttribution: AdamPS at AlbanyWeb commentedI found two instances where the subscribers value is still used.
1)
SendStatus::getMessage
Maybe can just remove the ?: and always call simplenews_count_subscriptions?2)
IssueItem::setValue
Can just delete this code I think.Comment #15
AdamPS CreditAttribution: AdamPS at AlbanyWeb commentedRe #14 First item is solved by latest patch in #3030432: Simplenews list page confusing/wrong "send status"
Comment #16
AdamPS CreditAttribution: AdamPS at AlbanyWeb commentedAfter thinking about it I think we should keep subscribers field = "number configured to send" because I see a valid distinction from the sent field = "number actually sent". Even when a newsletter issue has completed sending the two might be different because of skipped emails or errors that exceeded retry #3052714: Send failures retried forever. Let's not take time deleting something that has a little value!