Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ModernMantra’s picture

Status: Active » Needs review
FileSize
881 bytes

Small progress and new starting point :). Need to work on this in way to provide update config function.

ModernMantra’s picture

Created update config function. Tried with update database update function but did not succeed and could not provide useful patch for that (will need some instructions about that)

Status: Needs review » Needs work

The last submitted patch, 2: field_type-2421461-2.patch, failed testing.

ModernMantra’s picture

Status: Needs work » Needs review
FileSize
3.47 KB
2.26 KB

Made some progress, thanks to @berdir and his instructions and tutorial. Currently after debugging and running update function i got an error ALTER TABLE {node__simplenews_issue} CHANGE `simplenews_issue_subscribers` `` DEFAULT NULL;. Still a little more work on this, but i think this patch will be good starting point IMHO :-)

Status: Needs review » Needs work

The last submitted patch, 4: field_type-2421461-4.patch, failed testing.

ModernMantra’s picture

Small fix, hope test should pass now...

Status: Needs review » Needs work

The last submitted patch, 6: field_type-2421461-6.patch, failed testing.

The last submitted patch, 6: field_type-2421461-6.patch, failed testing.

The last submitted patch, 6: field_type-2421461-6.patch, failed testing.

ModernMantra’s picture

Status: Needs work » Needs review

Setting to needs review, re-ran multiple times the test on local machine with applied path and there is no single failure. Seems random test fails...

miro_dietiker’s picture

It seems we have a random fail here:

testSendNowCron
fail: [Other] Line 340 of modules/simplenews/src/Tests/SimplenewsSendTest.php:
Mail has correct subject
Value '[Default newsletter] wjBX]>&d&d'.

So it seems that there is a random fail if the newsletter random string contains HTML brackets lt, gt. Let's investigate in a follow-up. To start, change testSendNowCron() line 281 to the value above and reproduce the bug.

Status: Needs review » Needs work

The last submitted patch, 6: field_type-2421461-6.patch, failed testing.

AdamPS’s picture

Status: Needs work » Needs review
AdamPS’s picture

Status: Needs review » Needs work

I found two instances where the subscribers value is still used.

1) SendStatus::getMessage Maybe can just remove the ?: and always call simplenews_count_subscriptions?

2) IssueItem::setValue Can just delete this code I think.

AdamPS’s picture

Assigned: ModernMantra » Unassigned

Re #14 First item is solved by latest patch in #3030432: Simplenews list page confusing/wrong "send status"

AdamPS’s picture

Status: Needs work » Closed (works as designed)

After thinking about it I think we should keep subscribers field = "number configured to send" because I see a valid distinction from the sent field = "number actually sent". Even when a newsletter issue has completed sending the two might be different because of skipped emails or errors that exceeded retry #3052714: Send failures retried forever. Let's not take time deleting something that has a little value!