user.module.css contains visuals styles - they should be in user.theme.cs

This sounds noviceish

Ok, I will have a shot at this. :)

Patch attached.

- I added the new css file in the user.libraries.yml file
- I moved all styles having to do with presentational features (colors, etc) to the new file
- I left structural properties (layout, etc) in the old one.

Please review :)

Please ignore the previous patch, the newly added file was missing.

(using Sourcetree git GUI for this, and I missed one step).

Should be good to test now.

@vermario Thanks for picking this up! I did a manual test as well and found no regressions.

There is one minor code style issue that should be fixed before this patch can be committed:

+++ b/core/modules/user/css/user.theme.css
@@ -0,0 +1,26 @@
+/**
+ * Password strength indicator.
+ */

Every css file should start with a @file docblock. Suggestion:

+/**
+ * @file
+ * Styling for the Password strength indicator.
+ */

@mortendk Thanks for working on this issue. There is an effort to clear user.admin.css of lint errors in #1663210: Clean up css in the User module. Can you separate those changes from this patch to prevent scope creep?

I'm fine with using some default colors for the password indicator colors. On the other hand, one could also argue we should keep them in user.module.css file since the colors are not only visual but also functional.

1. +++ b/core/modules/user/css/user.module.css
   @@ -1,4 +1,5 @@
    /**
   + * @file
   ...
     */
   
   +++ b/core/modules/user/css/user.theme.css
   @@ -1,38 +1,42 @@
    /**
   + * @file
     * Password strength indicator.
     */
   

   Let's update the @file docblocks to indicate why the css is split up between user.module and user.theme.css files. Eg. 'Password strength indicator component.' for user.module.css and 'Visual styling for the Password strength indicator component.' for user.theme.css

2. From user.module.css
   

   div.password-confirm {
     visibility: hidden;
     width: 55%;
   }
   

   For consistency, let's move all width: 55%; code to theme or keep all of it in .module. Right now it is split between both.