Problem/Motivation

Following the css file naming (MAT) we have an issue with the forum module.
forum.module.css contains only css that should be placed in forum.theme.ss

documentation #1887922: [Obsolete] CSS file organization

Proposed resolution

move all css that's only visual to forum.theme.css

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#12 forum_module_css_file-2421099-10.patch566 byteslewisnyman
#9 forum_module_css_file-2421099-9.patch1.86 KBmortendk
#4 forum-no-style-2.png159.49 KBmortendk
#4 forum-no-style.png146.29 KBmortendk
#4 forum-with-style-2 .png157.74 KBmortendk
#4 forum-with-style.png144.18 KBmortendk
#2 forum_module_css_file-2421099-2.patch1.86 KBmortendk

Comments

mortendk’s picture

mortendk commented
Title: forum module cs follow the MAT » forum module css file follow MAT naming
mortendk’s picture

mortendk commented
Status: Active » Needs review
StatusFileSize
new forum_module_css_file-2421099-2.patch1.86 KB
lewisnyman’s picture

lewisnyman
he/him
commented
Issue tags: +Needs screenshots

Can we get a quick screen shot of the forum pages without the theme CSS just to verify that it is all functional? I can't think of a better way to check this

mortendk’s picture

mortendk commented
Issue summary: View changes
StatusFileSize
new forum-with-style.png144.18 KB
new forum-with-style-2 .png157.74 KB
new forum-no-style.png146.29 KB
new forum-no-style-2.png159.49 KB

screenshots added

edit: am i the only one that cant embed ?

lewisnyman’s picture

lewisnyman
he/him
commented

Are these without the .theme.css file? If it is then we should move the icons into the theme file, they shouldn't be required for functionality.

mortendk’s picture

mortendk commented

yup they are without any css at all to show that the forum module dont need any css at all to function

lewisnyman’s picture

lewisnyman
he/him
commented
Component: CSS » forum.module
Status: Needs review » Reviewed & tested by the community
Issue tags: -cssbanana, -Needs screenshots

Ah I see, yep the icons belong in .theme.css because they are only presentational.

Thanks for the screenshots!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
index 0000000..e7490f2
--- /dev/null

--- /dev/null
+++ b/core/modules/forum/css/forum.theme.css

@@ -2,4 +2,4 @@ forum.index:
-      css/forum.module.css: {}

I'm expecting the forum.module.css file to be renamed. It's not. So with this patch we would have two css files in forum.

mortendk’s picture

mortendk commented
Status: Needs work » Needs review
StatusFileSize
new forum_module_css_file-2421099-9.patch1.86 KB

this should remove the forum.module.css file :)

idebr’s picture

idebr commented

Should this patch also remove the forum.module.css?

mortendk’s picture

mortendk commented

yes is should cause forum.module.css has nothing that forum module needs its all theming - see screenshots

lewisnyman’s picture

lewisnyman
he/him
commented
StatusFileSize
new forum_module_css_file-2421099-10.patch566 bytes

Ah yes, here is the correct patch:

rteijeiro’s picture

rteijeiro commented
Status: Needs review » Reviewed & tested by the community

It works well even removing the CSS.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Templates are excluded from beta evaluation. Committed 588e75d and pushed to 8.0.x. Thanks!

  • alexpott committed 588e75d on 8.0.x 
    Issue #2421099 by mortendk, LewisNyman: forum module css file follow MAT...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.