Missing help text for external url only for link widget

+++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
@@ -144,6 +144,9 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
+      $element['uri']['#description'] .= $this->t('This must be an external URL such as %drupal.', array('%drupal' => 'http://example.com'));

oops. I forgot to take out the concatenations.

.=
should be just
=

+++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
@@ -220,12 +220,18 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
+      $element['uri']['#description'] = $this->t('This must be an internal URL such as %url.', array('%url' => '/node/nid'));

We do not need this. Because the UI is clear.
The text before the form makes it clear it is an internal URL, since it is the site prefix there.

We do not want to have helptext which does not add any information.

(bot hiccup)

+++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
@@ -227,6 +227,11 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
+    // If the field is configured to allow only external links,
+    // show a useful description.

I'll fix this right now.

"Lines containing comments (including docblocks) must wrap as close to 80 characters as possible without going over, with a few exceptions (noted in the Tag Reference below)."

https://www.drupal.org/node/1354#drupal

updated screenshots.
also beta summary evaluation.

ok. I'm working on one now.

just partial work. will fail.... the wrong way.

better. has a user with permission to create a node of the made content type.
this one passes. (but it checks for the help text for when both internal and external are allowed, which was correct in head). so that is ok.

next, make the test add link field that is external only, and test for the new help text for that.

oh, that breadcrumb thing.

I'll fix that eventually.

This is trying to make a link that is external only.
but I dont know how to set the $field_edit array correctly.... so it is just the same, both internal and external. :(

for the breadcrumb error.

I'm done for the day. Someone else can try and set the link type to external if they want to.
Note, LinkFieldTest looks like it might, but does not use the fieldUIAddNewField() on fieldUiTestTrait that I was hoping to use here.

+++ b/core/modules/link/src/Tests/LinkFieldUiHelptextTest.php
@@ -0,0 +1,86 @@
+    $field_edit = array(
+      'settings' => array(
+        'link_type' => LinkItemInterface::LINK_EXTERNAL,
+      ),
+    );
+    $this->fieldUIAddNewField($type_path, $field_name, $label, 'link', array(), $field_edit);

this is the bit that I think is wrong.

so, @jibran explained to me that this must be the name of the input field (not a nested array of whatevers).

admin/structure/types/manage/article/fields/node.article.field_another_link

fixed some nits. (help text is two words, and clarified some comments)

ok, I think this is ready for review.

Thanks! #40 is good.

I dont think we need #41.
We dont reference issues when we fix things, we just @todo issues that are still open that need to yet be done.
(We can use git blame to find out which issue added or changed a test.)

And, function one line summaries standard says:
starts with third person verb and is less than 80 chars.

https://www.drupal.org/node/1354#functions

re-uploading #40 (so it is the most recent patch, for clarity and also in case this gets rtbc, the testbot retests the most recent patch)

oh, crumbs. I missed that #40 changed LinkFieldUITest, and this issue is not about that class, but adding a new one for helptext tests.

but, the functions in the help text tests should be public.

@amateescu well, I'm planning to add a bunch more in #2421001: Fix regression in the link widget where help text does not show
for the various cardenality combinations and also something for the internal hint that is before the input field.
So, I was thinking having this separate group would make sense.

When we have a bunch, also, I was thinking they might have their own setUp to take care of some of the duplicate code.

but I can add them to LinkFieldUITest here, and move them later if we decide to.

ok. I will do that now.

just moving the tests to the other file.

another patch coming.

oops. forgot the use that I need in the new part of specifying the link type.

this puts the tests into one test, taking into account @amateescu feedback in #52 about not wanting a new install for each test.
This is now ready for a full review. (if it is green)

this fixes the fails. logs in as an new admin to make the second content type/field.

I'm not sure though if I should save the previous admin and user and log in as them again.

this makes and admin and content user and saves them for reuse.

oh, right. cause the permission is per content type. ....

thanks!

now on to #2421001: Fix regression in the link widget where help text does not show which should add tests for all the cases.