Also removed the @todo, I really hope it will not change again ;)

Comments

berdir’s picture

Status: Active » Needs review
StatusFileSize
new0 bytes

Status: Needs review » Needs work

The last submitted patch, 1: page-manager-user-path-2418131-1.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review
StatusFileSize
new1.31 KB

Arg.

Status: Needs review » Needs work

The last submitted patch, 3: page-manager-user-path-2418131-3.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review
StatusFileSize
new1.31 KB
berdir’s picture

Just learned that it should probably be base: and not user-path:, not really sure what exactly the difference is :) At least the theme path, maybe the other one *is* user input, even though indirectly?

berdir’s picture

StatusFileSize
new1.3 KB

Changed to base:.

tim.plunkett’s picture

Status: Needs review » Fixed

The first hunk should be user-path:, I fixed on commit. Thanks!

Status: Fixed » Needs work

The last submitted patch, 7: page-manager-user-path-2418131-7.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.