Include content type format name in error response

+++ b/core/lib/Drupal/Core/Routing/ContentTypeHeaderMatcher.php
@@ -47,7 +48,7 @@ public function filter(RouteCollection $collection, Request $request) {
+    throw new UnsupportedMediaTypeHttpException(String::format('No route found that matches the Content-Type header @format.', array('@format' => $request->headers->get('CONTENT_TYPE'))));

I think the String class is gone, so we need to use SafeMarkup instead.

Otherwise makes sense to me.

For other exceptions in core we just use sprintf(). Simple but effective;)

Implemented SafeMarkup::format().

Sorry for the previous patch.

The latest patch only includes the class of SafeMarkup but does not makes use of it. I think we still need to decide whether we should make use of SafeMarkup or make use of patch submitted in #14.

I think that I uploaded some old patch. Attached is the latest one and implements SafeMarkup::format().

Was able to solve one error but still one more error persists here: Line 99 of core/tests/Drupal/Tests/Core/Routing/ContentTypeHeaderMatcherTest.php
Can somebody help with that?

➜  d8 git:(migrationplugin) ✗ curl https://www.drupal.org/files/issues/include_content_type-2417917-22.patch|git apply
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1965  100  1965    0     0   3991      0 --:--:-- --:--:-- --:--:--  3993
➜  d8 git:(migrationplugin) ✗ ./vendor/phpunit/phpunit/phpunit -c ./core **/ContentTypeHeaderMatcherTest.php
PHPUnit 4.8.11 by Sebastian Bergmann and contributors.

...F

Time: 443 ms, Memory: 6.75Mb

There was 1 failure:

1) Drupal\Tests\Core\Routing\ContentTypeHeaderMatcherTest::testNoRouteFound
Failed asserting that exception message 'No route found that matches the Content-Type header <em class="placeholder">application/hal+json</em>.' contains 'No route found that matches the Content-Type header application/hal+json.'.

FAILURES!
Tests: 4, Assertions: 10, Failures: 1.

The %s gets converted to a placeholder. Perhaps you wanted to use sprintf ? Check for example core/lib/Drupal/Core/DependencyInjection/ClassResolver.php .

Re #15

➜  d8 git:(migrationplugin) ✗ ag 'throw.*sprintf' core |wc -l
112
➜  d8 git:(migrationplugin) ✗ ag 'throw.*SafeMarkup' core |wc -l
1

We use sprintf.

Actually, we use neither these days, just use plain string concatenation.

#2659070: REST requests without Content-Type header: unhelpful response significantly hinders DX, should receive a 415 response is closely related.

Looks good.

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!