Problem/Motivation

The Url::toArray() method is marked deprecated, and is redundant in the three places that it is currently used. Additionally, the unit test for the method is broken since #2347465: Convert all instances of #type link/links to convert to use routes and no longer even actually tests the method.

Proposed resolution

Remove Url::toArray().

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Prioritized changes This removes deprecated code that furthermore has broken test coverage, and reduces the API, so is potentially a prioritized change.
Disruption Minimal disruption because the function is already marked deprecated and only used internally in three places.

Remaining tasks

Patch NR.

User interface changes

None.

API changes

Deprecated method Url::toArray() is removed.

Comments

xjm’s picture

StatusFileSize
new3.46 KB

Missed one.

yesct’s picture

Status: Needs review » Needs work

seems to not be removing the method... :) but is removing the tests.
needs work to remove the method.

yesct’s picture

Status: Needs work » Needs review
StatusFileSize
new4.29 KB
new845 bytes

takes out core url toarray.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Great!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Yay, less code!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed c8f6f3c on 8.0.x
    Issue #2417445 by xjm, YesCT: Remove Url::toArray()
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.