Problem/Motivation

The Url::toArray() method is marked deprecated, and is redundant in the three places that it is currently used. Additionally, the unit test for the method is broken since #2347465: Convert all instances of #type link/links to convert to use routes and no longer even actually tests the method.

Proposed resolution

Remove Url::toArray().

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Prioritized changes This removes deprecated code that furthermore has broken test coverage, and reduces the API, so is potentially a prioritized change.
Disruption Minimal disruption because the function is already marked deprecated and only used internally in three places.

Remaining tasks

Patch NR.

User interface changes

None.

API changes

Deprecated method Url::toArray() is removed.

CommentFileSizeAuthor
#3 interdiff.2417445.1.3.txt845 bytesyesct
#3 2417445.3.patch4.29 KByesct
#1 routing-2417445-1.patch3.46 KBxjm
to-array.patch2.6 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
StatusFileSize
new routing-2417445-1.patch3.46 KB

Missed one.

yesct’s picture

yesct commented
Status: Needs review » Needs work

seems to not be removing the method... :) but is removing the tests.
needs work to remove the method.

yesct’s picture

yesct commented
Status: Needs work » Needs review
StatusFileSize
new 2417445.3.patch4.29 KB
new interdiff.2417445.1.3.txt845 bytes

takes out core url toarray.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Great!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Yay, less code!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed c8f6f3c on 8.0.x 
    Issue #2417445 by xjm, YesCT: Remove Url::toArray()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.