Convert Url::fromUri() base:// scheme to base:

Starter patch with a couple @todos. Some of these uses of base: are suspect, but many of them will be removed in #2412509: Change LinkItem.uri to type 'uri' rather than 'string' and introduce user-path: scheme.

So the test failure is because we have an assertion that relies on base:// not being a relevant scheme:

    // Add an invalid path from a random test failure.
    $this->drupalPostForm('admin/structure/views/nojs/display/test_view/page_1/path', array('path' => 'AKI@&hO@'), t('Apply'));
    $this->assertText('Invalid path');

Edit: Which is checking:

   if (!parse_url('base:' . $path)) {
      $errors[] = $this->t('Invalid path. Valid characters are alphanumerics as well as "-", ".", "_" and "~".');
    }

in PathPluginBase::validatePath().

[mandelbrot:~ | Thu 18:06:12] $ php -r "print_r(parse_url('base:AKI@&hO@'));"
Array
(
    [scheme] => base
    [path] => AKI@&hO@
)
[mandelbrot:~ | Thu 18:06:34] $ php -r "print_r(parse_url('base://AKI@&hO@'));"
[mandelbrot:~ | Thu 18:06:46] $ 

which was introduced to resolve the random failure #2353347: Random failure in DisplayPathTest which in turn was introduced by the original change. I wonder if we can remove this assertion?

Ah, yep, we can remove the assertion. The exact reason it was introduced was:

[10-Oct-2014 14:24:59 UTC] Uncaught PHP Exception InvalidArgumentException: "The URI "base://AKI@&hO@" is invalid. You must use a valid URI scheme. Use base:// for a path, e.g., to a Drupal file that needs the base path. Do not use this for internal paths controlled by Drupal." at /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Url.php line 207

Thrown in:

    if (!parse_url($uri, PHP_URL_SCHEME)) {
      throw new \InvalidArgumentException(String::format('The URI "@uri" is invalid. You must use a valid URI scheme. Use base: for a path, e.g., to a Drupal file that needs the base path. Do not use this for internal paths controlled by Drupal.', ['@uri' => $uri]));
    }

Updated for #2411333: Create standard logic to handle a entity: URI scheme and removed the assertion per #6.

Less reroll fail. Good night moon.

So a followup from #6, I think if we remove that assertion, we actually need to add an assertion in the Url tests that it is valid. Same possibly for the note elsewhere in the path about colons. Working on that and the other @todo.

Filed #2417459: Provide internal API for special schemes and thin public wrappers for user input and non-routed URLs.

Needs mega reroll followup #2350837: Convert most usages of EntityInterface::getSystemPath() to use routes.

Alright, that was fun.

Attached:

• Rerolls for #2350837: Convert most usages of EntityInterface::getSystemPath() to use routes.
• Expands the test coverage to cover many more URI formats with base:, including the one from the removed Views test.
• Addresses the @todos and earlier review.

I've also attached two -do-not-test.patch, one that contains only the // removals (review with git diff --color-words) and one that includes all the changes after that (for easier rerolling next time).

+++ b/core/tests/Drupal/Tests/Core/UnroutedUrlTest.php
@@ -69,20 +69,52 @@ protected function setUp() {
+    $this->assertSame($is_external, $url->isExternal());

@@ -104,118 +136,87 @@ public function testCreateFromRequest() {
-  /**
-   * Tests the isExternal() method.
-   *
-   * @depends testFromUri
-   *
-   * @covers ::isExternal
-   */
-  public function testIsExternal(array $urls) {
-    $this->assertTrue($urls[0]->isExternal());
-    $this->assertFalse($urls[1]->isExternal());
-  }

Oops, I meant to move this back out into its own method. Will do that shortly.

Needed a reroll again already. Also addresses #14.

Addresses #18.

Just to clarify, I have reproduced #19 only once out of dozens of test runs, so I've postponed that issue on it happening again and assuming #20 passes as expected we should be good here.

Updated for #2412509: Change LinkItem.uri to type 'uri' rather than 'string' and introduce user-path: scheme.

Unit test failure.