Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Jan 2015 at 15:04 UTC
Updated:
24 Mar 2015 at 14:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
cilefen commentedComment #2
cilefen commentedComment #3
cilefen commentedI manually tested the affected forms:
Comment #4
yesct commentedunrelated change.
I know it is difficult to resist, but only change lines that are needed to stay in scope.
Comment #5
cilefen commentedRemoved an unrelated change. Here is the grep command for finding usages:
Comment #6
cilefen commentedComment #7
yesct commentedsince this a new line, we can make it meet standards (but dont fix the lines above that are not changed by this patch).
https://www.drupal.org/node/1354#param
add the var name.
Comment #8
cilefen commentedFixed the omitted the parameter name in the EmailAction constructor.
Comment #9
yesct commentedpre-emptive rtbc, as it *should* come back green.
Read the whole thing and it stays in scope.
Comment #10
alexpottI think we can inject this too by implementing ContainerInjectionInterface.
We should be injecting the service here rather that using \Drupal.
Comment #11
cilefen commented@alexpott Thank you for reviewing.
Comment #13
cilefen commentedContactFormEditForm is injected. I don't know how to implement ContainerInjectionInterface in the context of static methods so \Drupal\Core\Render\Element\Email accesses the email.validator from \Drupal in this patch.
Comment #14
alexpott@cilefen sorry I missed that it was a static method - we have to leave a \Drupal :(
Comment #15
alexpottThis definitely can be injected :)
Comment #16
cilefen commented@alexpott I should have checked for that. I am sorry to waste your time.
Comment #17
abhi170893 commentedAfter applying the patch, the grep command for finding the usage of valid_email_address() gives only 1 result ( see issue summary):
Comment #18
alexpottCommitted bdb618d and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.