<?php
if ($flag->hasActionAccess('flag ' . $flag->id(), $account) || $flag->hasActionAccess('unflag ' . $flag->id(), $account)) {
?>

But hasActionAccess() clearly only expects either 'flag' or 'unflag' for the access param.

CommentFileSizeAuthor
#2 flag-2416517-2.patch523 bytesjoshi.rohit100
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lokapujya’s picture

lokapujya
Primary language English
Location Boston
CreditAttribution: lokapujya commented
Issue summary: View changes

Yes, I think $flag already knows its own id, so I think we just remove the appended id.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Active » Needs review
FileSize
flag-2416517-2.patch523 bytes

removed the flag-id added in hasActionAccess() method.

  • joshi.rohit100 authored 7d21058 on 8.x-4.x 
    Issue #2416517 by joshi.rohit100: Fix incorrect call to hasActionAccess...
socketwench’s picture

socketwench CreditAttribution: socketwench commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.