Closed (fixed)
Project:
Flag
Version:
8.x-4.x-dev
Component:
Documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Jan 2015 at 23:47 UTC
Updated:
12 Feb 2015 at 15:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
socketwench commentedYeah, sure.
Comment #2
lokapujyaUpdate for the parameter description.
First patch to Flag.
Comment #3
joachim commentedCool! Welcome to the Flag issue queue :)
Though we should have a single patch that's the whole fix, rather than two. Could you reroll, and incorporate the changes from both #1 and #2 please?
While we're at it, we should probably specify that $action can be one of 'flag' or 'unflag'.
Comment #4
lokapujyaNot sure what to do about the the parameter, because currently the following code exists that does not send 'flag' or 'unflag': (in FlagService.php)
Comment #5
joachim commentedThat's surely a bug, since the code as it stands is just going to deny access for that. Filed #2416517: Incorrect call to hasActionAccess() in getFlags(). Well spotted!
Let's go with what the code in the method in question says, and say it's either 'flag' or 'unflag'.
Comment #6
lokapujyaOk.
Comment #7
joachim commentedCongrats on you first commit to Flag! :)