Problem/Motivation

In the options form of webform_handler_field_submission_data class, the webform_datatype element has its default value set based on the format option.

Proposed resolution

Set the default value based on the webform_datatype option.

Remaining tasks

Review; add test (assume this was not caught due to absence of test)?

User interface changes

None.

API changes

None.

Comments

solotandem’s picture

Status: Active » Needs review
StatusFileSize
new1.22 KB

Attached patch implements proposed resolution.

Dan, even after reviewing the issue you linked to in the other issue I filed, am not sure what you wanted me to change about the patch or comment. Maybe ping me in IRC and explain (or send note to email in patch). Thanks.

danchadwick’s picture

Status: Needs review » Fixed

Thanks much!

Committed to 7.x-4.x and 8.x.

  • DanChadwick committed c66d1b0 on 7.x-4.x authored by solotandem
    Issue #2415019: Fix typo in default value for "webform_datatype" element...
  • DanChadwick committed 1b4c634 on 8.x-4.x authored by solotandem
    Issue #2415019: Fix typo in default value for "webform_datatype" element...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.