Currently, you only have access to Teams on your current Space. But if your Space is inheriting members from a parent Space, it should also inherit the parent Space's Teams!

Confirmed with Mike Potter that this was the desired behavior on IRC. I'll attach a patch soon!

CommentFileSizeAuthor
#2 oa_core-inherit-teams-2412483-2.patch9.15 KBdsnopek
#1 oa_core-inherit-teams-2412483-1.patch1.77 KBdsnopek

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs work
StatusFileSize
new oa_core-inherit-teams-2412483-1.patch1.77 KB

Attached is a patch that allows notifications to work for inherited Teams!

However, it doesn't allow them to be used in "Section Visibility" because that is using a View to build the list of options. Given the complexity of og_subgroups_parents_load() I don't think Views can be made to do this. A better approach would be like what Work Tracker does for the "Assigned to" field: it creates it's own entityreference_selection plugin which is capable of understanding Space inheritance.

That'll be in the next patch. :-)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs work » Needs review
StatusFileSize
new oa_core-inherit-teams-2412483-2.patch9.15 KB

Alright, this patch makes an entityreference_selection plugin to use with 'Section Visibility' and also updates the members widget to disable local teams and inherited teams seperately (so the user knows what they'll be affecting if they edit/delete the team).

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Component: Code » oa_core
mpotter’s picture

mpotter commented
Status: Needs review » Fixed

Did some testing on this and it looks good and fixes yet another important inheritance issue with subspaces. Thanks for the work on this David!

Committed to oa_core 46261ad.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.