Missing required method getEditableConfigNames() from ConfigFormBase. Patch incoming to fix. Can't install on 8.0.x HEAD.

CommentFileSizeAuthor
#5 Issue-2411955-Settings-form-missing-getEditableConfi.patch26.97 KBhass
#1 settings_form_missing-2411955-1.patch628 bytesmglaman

Comments

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: mglaman » Unassigned
Status: Active » Needs review
StatusFileSize
new settings_form_missing-2411955-1.patch628 bytes

Patch to add method!

hass’s picture

hass commented
Title: Settings form missing getEditableConfigNames method. » Settings form missing getEditableConfigNames method
Category: Bug report » Task

Is there any change note about this?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Here is the change record - https://www.drupal.org/node/2407153

Also, an issue in module upgrader (where I found change record link) #2409519: Config forms must implement getEditableConfigNames()

hass’s picture

hass commented
Status: Needs review » Needs work

Thanks for the link. This seems to require a lot more changes to the module.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new Issue-2411955-Settings-form-missing-getEditableConfi.patch26.97 KB

I guess something like this. Untested.

  • hass committed 63285a8 on 8.x-2.x authored by mglaman 
    Issue #2411955: Settings form missing getEditableConfigNames method
hass’s picture

hass commented
Status: Needs review » Fixed

I guess my patch is not correct. I do not understand this changes and it's impliations.

Committing for now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 1: settings_form_missing-2411955-1.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 5: Issue-2411955-Settings-form-missing-getEditableConfi.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Closed (fixed)