Currently on uninstall various fields are being deleted, which is less than ideal in my case as while I am removing the module I am keeping the content type, fields and data.

My suggested fix is that instead of just removing the fields, check if the fields have data, if not, go nuts, if so, don't touch.

CommentFileSizeAuthor
#3 do-not-remove-fields-when-uninstalling-2411913-3.patch725 bytesamit.drupal
#2 do-not-remove-fields-when-uninstalling-2411913-2.patch725 bytesavpaderno
#1 dont_del_fields-2411913-1.patch712 bytesdeciphered

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review
StatusFileSize
new dont_del_fields-2411913-1.patch712 bytes

Patch attached does as per my suggested fix.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
StatusFileSize
new do-not-remove-fields-when-uninstalling-2411913-2.patch725 bytes

I re-rolled the patch.

amit.drupal’s picture

amit.drupal commented
StatusFileSize
new do-not-remove-fields-when-uninstalling-2411913-3.patch725 bytes

I re-rolled the patch $2

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The placeholder is correct as in patch #2: %-placeholders are passed through check_plain(), but they are rendered in italic, as it is normally done with various nouns. See format_string().

  • drumm committed 5dd52d9 on 7.x-2.x authored by Deciphered 
    Issue #2411913 by Deciphered, kiamlaluno: Don’t remove fields on...
drumm’s picture

drumm
he/him
Location NY, US
commented

Looks okay, committed #2. Thanks!

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed
drumm’s picture

drumm
he/him
Location NY, US
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.