Metatags $form['#entity'] in metatag_metatags_form not set, uses entity 'token type'. [#2411477]

Hey,

We have a site translatable with i18n.
A problem we found is that the metatag data is saved correctly to the metatag table, but when you reedit the entity, the defaults are always shown.
This means when resaving, it saves the defaults.

I could pinpoint the problem to this snippet in metatags_metatags_form()

// Work out the language code to use, default to NONE.
  $langcode = LANGUAGE_NONE;
  if (isset($form['#entity_type']) && isset($form['#entity'])) {
    $langcode = metatag_entity_get_language($form['#entity_type'], $form['#entity']);
  }

On a node, $form['#entity_type'] is set to 'node',
$form['#entity'] is not set,
but $form['#node'] is set.

On a taxonomy_term, $form['#entity_type'] is set to 'taxonomy_term',
$form['#entity'] is not set,
but $form['#term'] is set.

Apparently the entity is available under the 'token type' info from enitity_get_info().
Code underneath fixes this.

// Work out the language code to use, default to NONE.
  $langcode = LANGUAGE_NONE;
  if (isset($form['#entity_type']) && $entity_info = entity_get_info($form['#entity_type'])) {
    if(isset($form['#' . $entity_info['token type']])) {
      $langcode = metatag_entity_get_language($form['#entity_type'], $form['#' . $entity_info['token type']]);
    }
  }

Patch coming up.

Cheers!
Tom

Comment	File	Size	Author
#20	metatag-n2411477-20.patch	1.14 KB	DamienMcKenna
#20
#17	metatag-entitytokeni18n-2411477-17.patch	1.16 KB	betz
#17
#10	metatag-n2411477-10.patch	856 bytes	DamienMcKenna
#10
#7	metatag-entitytokeni18n-2411477-7.patch	780 bytes	betz
#7
#3	metatag-entitytokeni18n-2411477-1.patch	936 bytes	betz
#3
#2	i18n_string-2227523-20.patch	800 bytes	betz
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 21 January 2015 at 14:39

Parent issue:

» #2376921: META: Plan for Metatag 7.x-1.5 release

Oh dear.

Comment #2

betz CreditAttribution: betz commented 21 January 2015 at 14:44

File	Size
i18n_string-2227523-20.patch	800 bytes

Comment #3

betz CreditAttribution: betz commented 21 January 2015 at 14:51

File	Size
metatag-entitytokeni18n-2411477-1.patch	936 bytes

Oops, wrong patch.
:)

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 21 January 2015 at 16:51

Status:

Active

» Needs review

Comment #5

21 January 2015 at 16:55

The last submitted patch, 2: i18n_string-2227523-20.patch, failed testing.

Comment #6

21 January 2015 at 16:56

Status:

Needs review

» Needs work

The last submitted patch, 3: metatag-entitytokeni18n-2411477-1.patch, failed testing.

Comment #7

betz CreditAttribution: betz commented 21 January 2015 at 20:23

File	Size
metatag-entitytokeni18n-2411477-7.patch	780 bytes

1 file was hidden/shown/deleted

File	Size
metatag-entitytokeni18n-2411477-1.patch	936 bytes

Comment #8

betz CreditAttribution: betz commented 21 January 2015 at 20:23

2 files were hidden/shown/deleted

File	Size
i18n_string-2227523-20.patch	800 bytes

metatag-entitytokeni18n-2411477-1.patch	936 bytes

Comment #9

betz CreditAttribution: betz commented 21 January 2015 at 20:24

Status:

Needs work

» Needs review

Comment #10

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 28 January 2015 at 02:02

File	Size
metatag-n2411477-10.patch	856 bytes

2 files were hidden/shown/deleted

File	Size
metatag-entitytokeni18n-2411477-1.patch	936 bytes

metatag-entitytokeni18n-2411477-7.patch	780 bytes

A minor simplification of the code.

Comment #11

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 28 January 2015 at 02:12

Status:

Needs review

» Fixed

Thanks! Am hoping this resolves some of the oddities others have been seeing lately.

Comment #12

28 January 2015 at 02:13

DamienMcKenna committed 4cea521 on 7.x-1.x authored by betz

Issue #2411477 by betz, DamienMcKenna: $form[#entity] doesn't work for...

Comment #13

m.lebedev CreditAttribution: m.lebedev commented 28 January 2015 at 07:37

Status:

Fixed

» Needs work

I encountered a problem after the upgrade module.

The site has a multi-lingual.
LOCATION: /en/taxonomy/term/%tid/edit/en
EntityMalformedException: Missing bundle property on entity of type taxonomy_term. in entity_extract_ids () (line 7766 of /www/includes/common.inc).

I did cancellation the current commit and the problem was gone.

Comment #14

betz CreditAttribution: betz commented 28 January 2015 at 09:37

Status:

Needs work

» Postponed (maintainer needs more info)

M.lebedev, can you give us some more info about your setup?
I can't seem to reproduce your error.

- Are you using the entity_translation or the i18n_taxonomy module for your vocabs?
- If you are using the i18n_taxonomy module, what is the tranlation setting of your vocab? 'Localize', 'translate', or 'fixed language'?
- What did you actual mean with 'I did cancellation the current commit'?

Comment #15

m.lebedev CreditAttribution: m.lebedev commented 28 January 2015 at 11:15

Drupal (7.34)
Enabled modules related to taxonomy:
entity_translation (7.x-1.0-beta4)
i18n_field_group
i18n_field
i18n (7.x-1.12)
i18n_menu
i18n_panels
path_breadcrumbs_i18n
i18n_string
i18n_translation
i18n_variable
i18nviews
taxonomy_menu (7.x-2.0-alpha2)

I did reverse commit 4cea521e9a1624bc897620bdcde30d4d64f3ad27 to fix this error.

Comment #16

betz CreditAttribution: betz commented 28 January 2015 at 11:45

Status:

Postponed (maintainer needs more info)

» Needs work

Jep, found the bug. It is specifically for entity translation.
Working on a patch that takes into account translations with both modules.

Comment #17

betz CreditAttribution: betz commented 28 January 2015 at 12:20

Status:

Needs work

» Needs review

File	Size
metatag-entitytokeni18n-2411477-17.patch	1.16 KB

OK. Could you test this patch against dev?

Comment #18

betz CreditAttribution: betz commented 28 January 2015 at 12:23

Also, about defaults:

the defaults for entity_translation are working fine.
The defaults for i18n (sub)modules depend on the entity_type:

Nodes are working fine
Terms are not.
Didn't test further

Terms defaults has its own issue, see #2030427: Integration with i18n_taxonomy for per-language defaults
This is not the scope of this issue...

Comment #19

m.lebedev CreditAttribution: m.lebedev commented 28 January 2015 at 13:45

Thanks. The patch metatag-entitytokeni18n-2411477-17.patch solves the problem.

Comment #20

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 28 January 2015 at 14:08

File	Size
metatag-n2411477-20.patch	1.14 KB

1 file was hidden/shown/deleted

File	Size
metatag-entitytokeni18n-2411477-17.patch	1.16 KB

Does this fix it?

Comment #21

m.lebedev CreditAttribution: m.lebedev commented 28 January 2015 at 14:55

Yes, #20 works.

Comment #22

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 28 January 2015 at 16:42

Status:

Needs review

» Fixed

Thanks! Committed.

Comment #23

28 January 2015 at 16:43

DamienMcKenna committed 4bd9160 on 7.x-1.x

Issue #2411477 by DamienMcKenna, betz: Follow-up to last change.

Comment #24

11 February 2015 at 16:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #25

GaëlG

he/him

French

Lille, France

CreditAttribution: GaëlG commented 25 June 2015 at 10:49

Status:

Closed (fixed)

» Needs review

In taxonomy_form_term, there is $form['#term'] = (array) $term; But we need to pass an object to metatag_entity_get_language(). This fixed the bug:

if (!empty($form[$entity_key])) {
  $entity = (object) $form[$entity_key];
  $langcode = metatag_entity_get_language($form['#entity_type'], $entity);
}

Comment #26

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 25 June 2015 at 11:50

Status:

Needs review

» Closed (fixed)

@GaelG: That bug was fixed in #2466629: EntityMalformedException thrown on taxonomy term edit page which was included in v1.5. Please update.

Also, please don't reopen old issues to report a different bug, and please only set an issue to "needs review" when there's a patch file to be reviewed.

Thank you.