Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
migration system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Jan 2015 at 04:57 UTC
Updated:
16 Feb 2015 at 10:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
chx commentedComment #3
benjy commentedNew patch fixes the fatal. The MigrationTest really isn't testing much to be honest. It was previously using the no_stub to skip most of the code in transform() and claiming to be a test for no_stub.
I vote for just deleting this test entirely? We have plenty of integration tests using the migrate process plugin.
Comment #5
benjy commentedAdded schema.
Comment #7
chx commentedCrappy tests can be deleted yes.
Comment #8
benjy commentedThe latest fails are because "plugin" is in the source but not in the values. That means we can remove it from the source or add it to the values. I went with the latter.
Comment #9
benjy commentedRemoved the test.
Comment #12
chx commentedBah, you shouldn't listen to me :) here's the relevant code from
Sourcetherefore the source configuration needs to be added to the values not the ids :/
Comment #13
chx commentedComment #15
chx commentedat first look, this means that filters needs a default array in the source (easy) but at second look, is this trying to stub a format?? Didn't we (try to) ban that?
Comment #16
andypost@chx maybe add a parent migration to import filter and pass stubbing?
Comment #17
chx commentedd6_comment and d6_custom_block both depend on d6_filter_format already
Comment #18
benjy commentedSome fixes.
Comment #20
chx commentedSee BlockPluginId:
->transform($deltawhere $delta is boxes.bid and not blocks.bid. The test confused blocks.bid for boxes.bid. Also, custom blocks can't be stubbed since there's a unique index containing info.As for comments, as the issue summary says, the source for comments.created (timestamp) needs a default. I went with 0.
I am leaving file for others :)
Comment #22
chx commentedComment #24
chx commentedHrm, file is not failing? Let's try this; the latest fail is trivial to fix.
Comment #26
benjy commentedNew patch attached.
Comment #27
benjy commentedPosted the last patch a little early, new patch coming soon.
Comment #28
benjy commentedOK, try this.
Comment #31
benjy commentedOK, this should be closer.
Comment #32
benjy commentedAccidentally left some changes in the Comment entity.
Comment #34
chx commentedComment #35
hosef commentedThis looks good. It works for me, and all tests pass.
Comment #36
chx commentedComment #37
alexpottmigration changes are not blocked in beta. Committed 9eb9661 and pushed to 8.0.x. Thanks!