Problem/Motivation

Add a new view
Create a page display, typing in the title should auto-fill the path, but it doesn't.

Proposed resolution

Include the views_ui/views_ui.admin library in the ViewAddForm

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 2410427-3.patch598 bytesidebr
#4 interdiff-3-1.txt570 bytesidebr
#3 2410427-3-before.png98.11 KBidebr
#3 2410427-3-after.png101.4 KBidebr
#1 2410427-1.patch578 bytesidebr

Comments

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 2410427-1.patch578 bytes
olli’s picture

olli commented 
+++ b/core/modules/views_ui/src/ViewAddForm.php
@@ -56,6 +56,7 @@ protected function prepareEntity() {
     $form['#attached']['library'][] = 'views_ui/admin.styling';
+    $form['#attached']['library'][] = 'views_ui/views_ui.admin';

That 'admin.styling' is a dependency of 'views_ui.admin' library so I think we can remove it.

idebr’s picture

idebr commented
StatusFileSize
new 2410427-3-after.png101.4 KB
new 2410427-3-before.png98.11 KB

Correct, thanks olli! Updated patch attached.

Screenshot before:

Screenshot after:

idebr’s picture

idebr commented
StatusFileSize
new interdiff-3-1.txt570 bytes
new 2410427-3.patch598 bytes

... and the patch.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
dawehner’s picture

dawehner
Primary language German
commented

I don't get why we have a separate one in the first place but well, you never know.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Thanks for adding the screenshots. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 35aad82 and pushed to 8.0.x. Thanks!

  • alexpott committed 35aad82 on 8.0.x 
    Issue #2410427 by idebr: admin/structure/views/add shoud include the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.