/**
 * Sets up page and article content types.
 */
abstract class BlockContentTestBase extends WebTestBase {

the class doesn't set up pages & article content types, but rather block content types.

CommentFileSizeAuthor
#18 custom_block_type-2409723-18.patch2.27 KBprashant.c
#16 custom_block_type-2409723-16.patch2.8 KBprashant.c
#13 update_comments-2409723-13.patch2.27 KBshashikant_chauhan
#11 custom_block_type-2409723-11.patch955 bytesprashant.c
#8 comment-coding-standard-2409723-8.patch509 bytesjaykandari
#5 2409723-comment-changed-5.patch509 bytesjaykandari

Comments

jaykandari’s picture

jaykandari
Primary language Hindi
commented

Can I replace the comment with "Sets up Block Content Types" ? I've never submitted a patch. Maybe a good starting point ? :P

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented

I would suggest low caps for consistency: Sets up block content types.

Indeed, this is a great starting point for learning how to create & submit patches :) Don't forget to assign the issue to yourself while working on it. Thanks

jaykandari’s picture

jaykandari
Primary language Hindi
commented
Assigned: Unassigned » jaykandari

Assigning Myself this issue (y)

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Thanks

jaykandari’s picture

jaykandari
Primary language Hindi
commented
StatusFileSize
new 2409723-comment-changed-5.patch509 bytes

Comment changed to "sets up block content types."

jaykandari’s picture

jaykandari
Primary language Hindi
commented
Status: Active » Needs review
dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented
Status: Needs review » Needs work

Looks good. Just a minor coding standards issue: the comment should start with a capital "S".

jaykandari’s picture

jaykandari
Primary language Hindi
commented
Status: Needs work » Needs review
StatusFileSize
new comment-coding-standard-2409723-8.patch509 bytes

Comment corrected to "Sets up block content types."

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented
Status: Needs review » Reviewed & tested by the community

looks great. setting to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: BlockContentTestBase has a wrong comment » Block tests refer to node incorrectly
Status: Reviewed & tested by the community » Needs work

Can we also fix the other incorrect references to node in the block_content module tests?

$this->assertNoText(t('This action cannot be undone.'), 'The node type deletion confirmation form is not available.');

in BlockContentTypeTest::testBlockContentTypeDeletion

 * Tests the node translation UI.

    // Create a node for each bundle.

in BlockContentTranslationUITest

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Needs work » Needs review
StatusFileSize
new custom_block_type-2409723-11.patch955 bytes

Attaching patch to correct the block type deletion confirmation.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Needs work

@Prashant.c can you add #8 to your patch and the other one @alexpott mentioned in #10?

shashikant_chauhan’s picture

shashikant_chauhan commented
StatusFileSize
new update_comments-2409723-13.patch2.27 KB

Included all comment changes in one patch

shashikant_chauhan’s picture

shashikant_chauhan commented
Status: Needs work » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Had a last check and there is still one more reference to node. It's in the class name in block-content-add-list.html.twig

node-type-list

Should be

block-type-list

Then I think this is RTBC. Thanks for the correction @shashikant_chauhan

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
StatusFileSize
new custom_block_type-2409723-16.patch2.8 KB

Attaching patch with all the changes including the class name in .twig file.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Needs work

Sorry chasing head a bit here, but just happened across another issue that totally removed that class and it was committed this morning. So to keep up with HEAD, lets remove it here as well.

#2412373: Remove node-type-list from block-content-add-list.html.twig

Sorry for instructing the change, didn't know it was on the chopping block at the time.

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
StatusFileSize
new custom_block_type-2409723-18.patch2.27 KB

Pulled the latest code today and could not find

with "node-type-list" as removed in https://www.drupal.org/node/2412373 so submitting updated patch.
prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Needs work » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Assigned: jaykandari » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +doc

Great thank you, I think this is good to go now.

I've checked for extra references to nodes and this covers the ones @alexpott mentioned in #10

These are all Doc and Test message changes so there should be nothing holding it back from getting into beta.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue tags: -doc +Documentation
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Only changes tests and therefore not subject to beta evaluation. Committed 0f8f656 and pushed to 8.0.x. Thanks!

  • alexpott committed 0f8f656 on 8.0.x 
    Issue #2409723 by Prashant.c, JayKandari, shashikant_chauhan: Block...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.