Updater::findInfoFile() lacks test coverage

I think @mark.labrecque has some, I'll get them from him tomorrow and try to nail this one down.

@joshi.rohit100 unless you want to tackle this? Please take it from me:)

My ability to write tests is poor but this should do the trick. I'm trying to write a unit test but ran into two problems and I'm sure there is someone out there that knows a more elegant solution.

Problem 1. Had to include file.inc in the method because Updater breaks encapsulation by using file_scan_directory() in it's method.

Problem 2. I had to add InfoParser to a new container because the container and the service is NULL. This one is the one I think would be easier to solve as I bet there is a way to get that in setUp or something better.

1. +++ b/core/tests/Drupal/Tests/Core/Extension/ModuleHandlerTest.php
   @@ -511,4 +514,23 @@ public function testGetModuleDirectories() {
   +    // Load the info parser onto the container for the Updater to use.
   +    $container = new ContainerBuilder();
   +    $container->set('info_parser', new InfoParser());
   +    \Drupal::setContainer($container);
   

   Is there a better place and method of doing this?

2. +++ b/core/tests/Drupal/Tests/Core/Extension/ModuleHandlerTest.php
   @@ -511,4 +514,23 @@ public function testGetModuleDirectories() {
   +    // Include file.inc for Updater because it uses file_scan_directory().
   +    include_once $this->root . '/core/includes/file.inc';
   

   Don't like this, breaks encapsulation. Ideas?

3. +++ b/core/tests/Drupal/Tests/Core/Extension/modules/module_handler_test_multiple/module_handler_test_multiple_child/module_handler_test_multiple_child.info.yml
   @@ -0,0 +1,7 @@
   +core: 8.x
   ...
   \ No newline at end of file
   

   Whoops, easy fix;)

Ok fixing the EOF newline, and moving a line under the comment it belongs. I think this is probably the best MVC we can do from @benjy's comment.

To test this you may need this #2042447-58: Install a module user interface does not install modules (or themes)

Dang, don't know what changed in head:(

+++ b/core/tests/Drupal/Tests/Core/Extension/ModuleHandlerTest.php
@@ -511,4 +514,24 @@ public function testGetModuleDirectories() {
+    include_once $this->root . '/core/includes/file.inc';

Now needs 'file_system' service on the container... this test seems to be balooning out of control for a 1 character fix...

@webchick save me from this.

I think this needs a kernel test or something to avoid that type of include in the test.

1. +++ b/core/modules/system/src/Tests/Extension/InfoParserTest.php
   @@ -0,0 +1,102 @@
   + * Contains \Drupal\system\Tests\Extension\InfoParserTest.
   
   +++ /dev/null
   @@ -1,87 +0,0 @@
   - * Contains \Drupal\system\Tests\Extension\InfoParserUnitTest.
   

   Poorly named class because it's not a unit test.

2. +++ b/core/modules/system/src/Tests/Extension/InfoParserTest.php
   @@ -0,0 +1,102 @@
   +use Drupal\Core\Updater\Updater;
   ...
   +  /**
   +   * Tests loading a project with a child project will display the correct
   +   * project title.
   +   *
   +   * @see https://drupal.org/node/2409515
   +   */
   +  public function testGetProjectTitleWithChild() {
   +    // Get the project title from it's directory. If it can't find the title
   +    // it will choose the last project title in the directory.
   +    $directory = \Drupal::root() . '/core/modules/system/tests/modules/module_handler_test_multiple';
   +    $title = Updater::getProjectTitle($directory);
   +    $this->assertEqual('module handler test multiple', $title);
   +  }
   

   Only additions to this file.

I'll be nicer here. The rename is moved here #2490388: InfoParserUnitTest web test classes mislabeled as unit tests which has a meta for that cause.

@dawehner the move is over here #2490388: InfoParserUnitTest web test classes mislabeled as unit tests so this patch is easy to read.

Thanks for the review @lauriii

It's now taking the first project not the last as it did before. Minor comment fix in test.