Variable to config: search.settings [d7]

Added organization support to Anexus IT

Will need to be submitted again to Core since moving from sandbox.

Updated for HEAD, and wrote a test.

reroll

And moved to the search module.

There is disparity between the D6 and D7 versions of this migration; the D6 one selects several variables which are never mentioned in the process pipeline. That's a WTF and should be addressed before this gets committed.

The differences your've spotted are nicely outlined in the know issues documentation, specifically
Search Settings. According to that D7 contains 2 variables, search_tag_weights and search_and_or_limit, that are not in D6 or D8.

However, looking at D8 search settings it seems that 'search_and_or_limit' is now 'and_or_limit' and 'search_tag_weights' is now 'tag_weights'.

Since this issue is clearly marked D7, I'll make a new issue for the change to d6_search_settings.yml.

Added migration for 'search_and_or_limit' and 'search_tag_weights' and tests.

I do think it's helpful for long-term maintenance to keep the D6 and D7 tests as in-sync as possible - the only differences should really be inherent differences between D6 and D7.

1. +++ b/core/modules/search/migration_templates/d7_search_settings.yml
   @@ -0,0 +1,28 @@
   +dependencies:
   +  module:
   +    - migrate_drupal
   +    - search
   

   The module dependencies are unnecessary and should be removed.

2. +++ b/core/modules/search/src/Tests/Migrate/d7/MigrateSearchSettingsTest.php
   @@ -0,0 +1,58 @@
   + * Contains \Drupal\search\Tests\d7\MigrateSearchSettingsTest.
   

   Discrepancy from D6, where this is called MigrateSearchConfigsTest.

3. +++ b/core/modules/search/src/Tests/Migrate/d7/MigrateSearchSettingsTest.php
   @@ -0,0 +1,58 @@
   +    $this->installConfig(static::$modules);
   

   Why is installConfig necessary here but not in the D6 test?

4. +++ b/core/modules/search/src/Tests/Migrate/d7/MigrateSearchSettingsTest.php
   @@ -0,0 +1,58 @@
   +  public function testMigration() {
   

   Discrepancy with D6, where this is testSearchSettings().

5. +++ b/core/modules/search/src/Tests/Migrate/d7/MigrateSearchSettingsTest.php
   @@ -0,0 +1,58 @@
   +    $config = \Drupal::config('search.settings')->get();
   

   Can use $this->config here (see the D6 test).

All fixed.

Committed and pushed to 8.0.x. Thanks!