Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
migration system
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Jan 2015 at 22:51 UTC
Updated:
17 Aug 2015 at 17:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
hosef commentedAttached is the YAML for this issue, from the patch in #2382117: Migration Files for Drupal 7 Variables.
Test(s) (and maybe a dump file) still need to be written.
Comment #2
miguelc303 commentedAdded organization support to Anexus IT
Comment #3
jcost commentedWill need to be submitted again to Core since moving from sandbox.
Comment #4
phenaproximaEver drop an issue summary in a comment? It happened to me.
Comment #5
phenaproximaComment #6
phenaproximaUpdated and wrote a test.
Comment #7
phenaproximaRe-rolled. I regret that I can't provide an interdiff, due to the conflicts in the {variable} table dump.
Comment #8
phenaproximaRe-rolled in accordance with #2533886: [meta] Move module-specific migration support into the particular modules supported.
Comment #9
chx commentedI think we agreed before on asserting empty strings and similar defaults buys us nothing.
Comment #10
phenaproximaFixed. Can't include an interdiff, unfortunately, due to conflicts with the {variable} dump.
Comment #11
chx commentedLooks great.
Comment #14
webchickThanks to @phenaproxima and @mikeryan for the patch walk through. I'm a little rusty on this Migrate stuff, but hoping to get better starting today. :)
phenaproxima confirmed to me that he's gone through the module painstakingly to ensure these are all the variables that need migrating. In my cursory check that seems to be correct.
This one:
I called specific attention to as in "we can't possibly store the httpauth_password in plain text, can we?" It turns out, we can. :( Confirmed on a fresh 7.x database.
I had no idea wtf that was, and phenaproxima explained it's a sanity check to ensure the migrate-drupal.sh script was invoked properly. Seems like that makes it really easy for collisions/long issue dependency chains to happen. :\ Not introduced in this patch, though.
The nittiest of picks, but that should be SimpleTest. ;) Fixed on commit. This doesn't show up anywhere in core, but does in the full Migrate UI that's currently housed in the https://www.drupal.org/project/migrate_plus project.
Wasn't sure what that 'httpauth/method' stuff was about, but was explained that this is the format for arrays of config. Since method, password, and userame are all related, makes sense in the new system to store them under a single httpauth array.
Everything else in here was straight-forward, so committed and pushed to 8.0.x. Thanks! Onto the next variable-to-config migration! :D