Comments

xano’s picture

This needs a check to ensure the entity can be added through the UI. Entities like contact form messages and payments shouldn't just be added anywhere. IIRC Rules for Drupal 7 uses a simple boolean flag in the entity type definition. Maybe we can do the same here?

bojanz’s picture

Assigned: Unassigned » bojanz
bojanz’s picture

Assigned: bojanz » Unassigned
Status: Active » Needs work

My current progress is up at https://github.com/fago/rules/pull/146

I was unable to complete this because of issues with the test framework, as discussed with fago.

We also decided to skip the check in #1, if an entity type is able to be constructed using entity_create(), then the same reasons apply to this action. Modules with corner cases can alter the definition and unset the derivative for the entity type they want to hide.

fago’s picture

Issue tags: +Needs tests

Thanks, I commented the PR - functionality basically looks great. So it's "just" missing tests then.

mariancalinro’s picture

Assigned: Unassigned » mariancalinro

I am writing the tests for this @drupaldevdays Montpellier.

dasjo’s picture

Issue tags: +drupaldevdays
mariancalinro’s picture

Issue tags: -drupaldevdays
mariancalinro’s picture

Status: Needs work » Needs review
Issue tags: +drupaldevdays
mariancalinro’s picture

Assigned: mariancalinro » Unassigned
klausi’s picture

Status: Needs review » Fixed

Merged, thanks!

  • klausi committed 8f48889 on 8.x-3.x authored by bojanz
    Issue #2409055 by mariancalinro, bojanz: Port Create a new entity (...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.