Comments

manjit.singh’s picture

Status: Active » Closed (duplicate)
Issue tags: +mobile/responsive, +blocks admin page

It feels like this was succeeded by #2280035: Add another responsive tables solution that doesn't hide content.. Feel free to reopen though.

nitishchopra’s picture

Status: Closed (duplicate) » Active
ram4nd’s picture

Issue tags: -mobile/responsive +mobile

Changed the tag for consistancy by Topical issue tags.

manjit.singh’s picture

Issue tags: +frontend
alexandr.khlopkov’s picture

Assigned: Unassigned » alexandr.khlopkov
alexandr.khlopkov’s picture

Status: Active » Needs review
StatusFileSize
new1.86 KB

patch with alignment "system bread crumbs" menu (and not only) is missaligned structure->blocks (bartik theme)

Status: Needs review » Needs work

The last submitted patch, 6: system-breadcrumbs-2409009-6.patch, failed testing.

manjit.singh’s picture

Issue tags: +rc deadline

I hope we can close it till the first release of Drupal 8. tagging it with + rc deadline

meenakshi.r’s picture

Issue tags: +Needs reroll
meenakshi.r’s picture

Title: system bread crumbs menu is missaligned for iphone 5 and 360*640 resolution under structure->blocks( bartik theme) » System breadcrumbs menu is missaligned for iphone 5 and 360*640 resolution under structure->blocks( bartik theme)
joelpittet’s picture

RC deadline has past but I think this can likely be fixed? Tagging for release manager review.

But this issue really needs screenshots in the issue summary to show the problem.

alvar0hurtad0’s picture

Issue summary: View changes
StatusFileSize
new130.59 KB

Now,

this is how we can see the /admin/structure/block page at the moment.

alvar0hurtad0’s picture

Assigned: alexandr.khlopkov » Unassigned
StatusFileSize
new2.08 KB

@alexandr.khlopkov I'm not sure if you're still working. I've done the reroll.

alvar0hurtad0’s picture

Status: Needs work » Needs review

I forgot the status

iamDamon’s picture

+++ b/core/modules/system/css/components/tabledrag.module.css
@@ -20,13 +20,26 @@ tr.region-populated {
+    justify-content:center;
+    align-content:center;
+    flex-direction:column;

wrong indentation and missing a space after the colon

manjit.singh’s picture

StatusFileSize
new2.08 KB

correct Indentation and Adding space as per #18.

xjm’s picture

As a straight bugfix, this could potentially go into 8.0.x. However, looking at the patch, the CSS changes seem like they are broader than just the bug being fixed, and might also disrupt themes. Tagging for a CSS maintainer to help evaluate whether the fix is correct and what would be safe for existing themes and sites in 8.0.x. Thanks!

Reference: https://www.drupal.org/core/d8-allowed-changes#patch

Fred Martin’s picture

Issue tags: -Needs reroll

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

cilefen’s picture

Issue tags: -Novice

I removed the Novice tag because we are waiting for a maintainer's opinion.

iamanupmenon’s picture

StatusFileSize
new42.56 KB

I tested #19 patch and am still facing the same issue.
image

iamanupmenon’s picture

Status: Needs review » Needs work
brahmjeet789’s picture

StatusFileSize
new2.21 KB

@iamanupmenon i have created patch for this,please test and review it.

brahmjeet789’s picture

Status: Needs work » Needs review
chernous_dn’s picture

StatusFileSize
new25.56 KB

Hi @brahmjeet789 looks fine, attach screenshot. Test on dev 8.1

chernous_dn’s picture

StatusFileSize
new14.53 KB

But you created patch with errors, 87 ++.draggable .block { attach screenshot. And you need add space here + justify-content:center; like this justify-content: center;

chernous_dn’s picture

Status: Needs review » Needs work
Vidushi Mehta’s picture

Status: Needs work » Needs review
StatusFileSize
new2.21 KB

Here is the updated one. Please review.

chernous_dn’s picture

Hi @Vidushi Mehta the same error 87 ++.draggable .block {

chernous_dn’s picture

StatusFileSize
new2.21 KB

Update patch from #31

NikitaJain’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new22.95 KB
new26.27 KB
new30.76 KB

Verified and tested the above patch (system_breadcrumbs_menu-2409009-33.patch) on dev 8.1. The patch applied successfully and its working fine. Screenshots attached.

star-szr’s picture

Version: 8.1.x-dev » 8.3.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)
Issue tags: -blocks admin page, -Needs subsystem maintainer review
StatusFileSize
new112.39 KB

The patch in #33 won't have any effect when viewing core themes (Seven or Bartik) because at this point they both inherit from the Classy (and Stable) base themes, not the CSS in core/modules.

I think we need clear before and after screenshots and an updated issue summary (both tags are already there), I'm not sure from the issue summary or any comments or screenshots what the bug is that we're fixing. Looking at the code it seems to be something to do with the tabledrag but based on the title I would think it's relating to the breadcrumbs shown on that admin page.

Wait, is this talking specifically about the breadcrumbs block tabledrag row on the block layout page? The breadcrumbs block has a longer first word than most of the other blocks which causes it to look different at narrower resolutions. Attaching a screenshot:

If I have correctly decoded the bug described here (if this is the bug it shouldn't have taken this much of a leap to arrive at this conclusion), my opinion after looking at the screenshot is I'm not sure it's worth the fuss unless we can fix this in a generic way that will also work for longer words/titles. I suspect the proper solution may be larger than the scope of an issue like this, for example #2280035: Add another responsive tables solution that doesn't hide content as was pointed out in #1. Thanks everyone for your time so far.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

Status: Postponed (maintainer needs more info) » Closed (outdated)

This has been a year with no response to @Cottser so I'm closing for now