The module like to handle every thrown exception as a watchdog error. But most of the time a warning should be enough.

In this way our central logging system stays happy :)

CommentFileSizeAuthor
#2 handle-not-every-exception-as-a-watchdog-error-2408693-02.patch2.38 KBtessa bakker
#1 handle-not-every-exception-as-a-watchdog-error-2408693.patch2.15 KBtessa bakker

Comments

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new handle-not-every-exception-as-a-watchdog-error-2408693.patch2.15 KB
tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
StatusFileSize
new handle-not-every-exception-as-a-watchdog-error-2408693-02.patch2.38 KB

Here is a new patch, this one handles 'Zero results' returned by Google as a watchdog notice.

spadxiii’s picture

spadxiii commented

In the yandex.inc you do 'throw new Exception($msg, WATCHDOG_WARNING);' but in the part that's similar in google.inc, you do 'throw new Exception($msg, WATCHDOG_ERROR);'. Shouldn't both be errors?

adamps’s picture

adamps commented
Category: Feature request » Bug report
Status: Needs review » Reviewed & tested by the community

Patch works for me thanks. The "zero results" was the crucial one that was flooding my log with errors. I've changed the issue category to a bug report on the basis that it seems to be an existing function that's not working correctly.

In terms of #3 by SpadXIII - presumably the correct level would depend how readily the message can occur. For example if it can come from just a network glitch, warning is probably right. However I don't use yandex so I can't comment on that. If the yandex part is in doubt, I'd still appreciate a commit of the google part, thanks.

basvredeling’s picture

basvredeling
Primary language Dutch
Location Amsterdam
commented

+1 this patch is ok.

@SpadXIII the yandex part seems to cover all kinds of warnings, not just connection fails. Hence the difference in error level.

simon georges’s picture

simon georges commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

adamps’s picture

adamps commented

This fix was released into v1.3 Unfortunately some other changes in the v1.3 release broke the function again.

I have raised a new issue #2689211: Confusion with errors and logging.