Remove classes from system templates d*.html.twig

Postponing this until we decide how we are moving forward. Keep an eye on #2348543: [meta] Consensus Banana Phase 2, transition templates to the starterkit theme for updates. Thanks.

Un-postponing. The templates have been copied to Classy, so all we need to do is remove classes from the original templates.

.details-wrapper is used by views-ui so not relevant (views-ui not copied to classy so no need for seperation)
.details-descriptionis purely cosmetic
.dropbutton-widget is build on js the classname is changed to js-* to make it clear for the themer that this is a class thats used by js.

@mortendk Looking into #3 patch, Everything seems fine but Why automate test fails ?

Remove classes from datetime-form.html.twig

@manjit: the "container-inline" class in datetime-form.html.twig was removed in the previous patch, also you forgot the rest of the patch ;)

I added a missing test for js-dropbotton, see interdiff

works better when the patch is uploaded ;)

set test to classy

Cant reproduce on my local everytest passes there, set to retest

Screenshots for dropbotton:

@mortendk is right. That tests are wrong even before applying this patch. I think it's a RTBC, check screenshots:

Views BEFORE

Views AFTER

You are rtbc-ing a red patch. We have to have it come back green. If it is passing locally, but failing on testbot, that is something we need to look into.

+++ b/core/misc/dropbutton/dropbutton.css
@@ -87,15 +87,15 @@
-.js .dropbutton-multiple .dropbutton-widget {
+.js .dropbutton-multiple .js-dropbutton-widget {
...
-.js[dir="rtl"] .dropbutton-multiple .dropbutton-widget {
+.js[dir="rtl"] .dropbutton-multiple .js-dropbutton-widget {

This makes me even more reserved about adding js- to classes that are in the template. Sure if javascript adds the class and does whatever.

js- classes must be added if a class is used for js, but what we might have to do is now refactor all of the css out of this mess & add in new classes etc.

I would suggest that we remove those files out of this commit so we can take each of the js infected files and clean them up, but dont hold the rest back ?

the dropbotton css component needs to be rewritten - would it make sense to move that to a seprate issue ?

I have looked at the dropbutton component, and have decidet to remove it from this issue - create a seperate issue for it. Theres to amny otherthings going on inside of dropbutton that potentially can drag on forever (test, classname bikeshed etc)
Dropbotton issue
#2428193: make dropbutton component follow css coding standards

New patch uploaded without dropbutton-wrapper.html.twig

+++ b/core/modules/system/templates/datetime-wrapper.html.twig
@@ -15,16 +15,10 @@
-    required ? 'form-required',

This is sketchy, removing this from core because it's functionality.

Everything else I'm cool with.

.form-required is used in /core/misc/states.js:

if i read it right it removes required with js from <foo required>?

$(document).on('state:required', function (e) {
    if (e.trigger) {
      if (e.value) {
        var $label = $(e.target).attr({'required': 'required', 'aria-required': 'aria-required'}).closest('.form-item, .form-wrapper').find('label');
        // Avoids duplicate required markers on initialization.
        if (!$label.hasClass('form-required').length) {
          $label.addClass('form-required');
        }
      }
      else {
        $(e.target).removeAttr('required aria-required').closest('.form-item, .form-wrapper').find('label.form-required').removeClass('form-required');
      }
    }
  });

looks like we have another case of .js-banana

the js dependency on the classes needs to be fixed with all the other js / css issues in #2408473: Rewrite form.css inline with our CSS standards

Ok, let's try to clean-up js classes in a different issue. Back to RTBC!

No longer applies, presumably because of #2378883: Convert existing drupal_render() KernelTestBase tests to PHPUnit tests.

+++ b/core/modules/system/src/Tests/Common/RenderTest.php
@@ -581,6 +581,10 @@ function testDrupalRenderChildrenPostRenderCache() {
 
+    // Enable the Classy theme.
+    \Drupal::service('theme_handler')->install(['classy']);
+    $this->config('system.theme')->set('default', 'classy')->save();
+

This looks quite odd. Fortunately this hopefully won't be necessary anymore with that test now turned into unit tests instead.

hurray ok lets see where this goes

Looks good and solves the issues mentioned by @webchich on #36.

ps. In future decent naming and .patch in the end of file would rock.

Changing templates is permitted in beta. Committed 44323cf and pushed to 8.0.x. Thanks!