Bootstrap adds trailing slash if the title have been removed and the page does have a menu item, example of this is having a panel (page manager) with title set to "No title", bootstrap theme will add a slash though the data is empty.

CommentFileSizeAuthor
#8 bootstrap_breadcrumb-2407245-8.patch1.09 KBneardark
#5 bootstrap_breadcrumb-2407245-5.patch1.1 KBneardark
#1 bootstrap_breadcrumb-2407245-1.patch947 bytesmkhamash

Comments

mkhamash’s picture

mkhamash commented
Status: Active » Needs review
StatusFileSize
new bootstrap_breadcrumb-2407245-1.patch947 bytes

Checking if the title is empty, to prevent printing empty title

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed

  • markcarver committed 3b2c2d6 on 7.x-3.x authored by mkhamash 
    Issue #2407245 by mkhamash: bootstrap breadcrumb add trailing slash if...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: Unassigned » neardark
Priority: Minor » Major
Status: Fixed » Patch (to be ported)

@neardark, I tried applying this to the 8.x branch, but for some reason the entire second portion of breadcrumbs.vars.php is now gone and is no longer in parity with the 7.x branch. It shouldn't have been removed.

neardark’s picture

neardark commented
StatusFileSize
new bootstrap_breadcrumb-2407245-5.patch1.1 KB

Bahhh. Sorry about that.

neardark’s picture

neardark commented
Status: Patch (to be ported) » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: bootstrap_breadcrumb-2407245-5.patch, failed testing.

neardark’s picture

neardark commented
Status: Needs work » Needs review
StatusFileSize
new bootstrap_breadcrumb-2407245-8.patch1.09 KB

Status: Needs review » Needs work

The last submitted patch, 8: bootstrap_breadcrumb-2407245-8.patch, failed testing.

The last submitted patch, 8: bootstrap_breadcrumb-2407245-8.patch, failed testing.

  • neardark committed 77d1be8 on 8.x-3.x 
    Issue #2407245 by neardark: bootstrap breadcrumb title work
neardark’s picture

neardark commented
Assigned: neardark » markhalliwell
Status: Needs work » Patch (to be ported)

Code re-added to breadcrumb.vars.php

neardark’s picture

neardark commented
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Patch (to be ported) » Fixed

Cool. Thanks :) I wasn't sure if menu_get_item() still existed in 8.x or not, guess it does.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: markhalliwell » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.