Consider introducing AjaxResponse::addAttachments() [#2407201]

Problem/Motivation

From #2368797-50: Optimize ajaxPageState to keep Drupal 8 sites fast on high-latency networks, prevent CSS/JS aggregation from taking down sites and use HTTP GET for AJAX requests:

+++ b/core/lib/Drupal/Core/Ajax/AjaxResponse.php
@@ -26,6 +27,32 @@ class AjaxResponse extends JsonResponse {
+  public function setAttachments(array $attachments) {
+    $this->attachments = $attachments;
+    return $this;
+  }
This method just replaces the attachments with a new value. Thinking also about #2347469: Rendering forms in AjaxResponses does not attach assets automatically, we may have several Ajax commands in a response, each targeting a different portion of the form, and each having its own attached assets. So, wouldn't it make sense to have a method that incrementally merges the input instead?

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

None.

API changes

TBD

Comment	File	Size	Author
#8	interdiff.txt	1.17 KB	wim leers
#8	2407201-8.patch	30.21 KB	wim leers
#5	interdiff.txt	3.13 KB	wim leers
#5	2407201-5.patch	30.2 KB	wim leers
#3	2407201-3.patch	27.57 KB	wim leers

Comments

Comment #1

andypost

he/him

Russian

commented 14 January 2015 at 18:06

So we are going to... depending on a kind of response to manage assets differently?

Comment #2

wim leers

Ghent 🇧🇪🇪🇺

commented 22 January 2015 at 12:42

Status:

Postponed

» Active

The parent issue landed, we can work on this now.

Status	File	Size
new	2407201-3.patch	27.57 KB

Comment #4

wim leers

Ghent 🇧🇪🇪🇺

commented 22 January 2015 at 15:08

#1: Basically: yes. Before #2368797: Optimize ajaxPageState to keep Drupal 8 sites fast on high-latency networks, prevent CSS/JS aggregation from taking down sites and use HTTP GET for AJAX requests, we implicitly relied on statics in _drupal_add_(css|js)(). We've been working towards removing those for several years. Finally it has happened. For HTML responses, we render everything inside html.html.twig, and then use #attached to determine which <script> and <link rel="stylesheet"> tags to render. For AJAX responses, we don't have that; there can be multiple AJAX commands in an AJAX response, each needing assets, and potentially the same. Hence :;addAttachments().

Comment #5

wim leers

Ghent 🇧🇪🇪🇺

commented 22 January 2015 at 15:16

Status	File	Size
new	2407201-5.patch	30.2 KB
new	interdiff.txt	3.13 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	2407201-3.patch	27.57 KB

Addressing #2368797-65: Optimize ajaxPageState to keep Drupal 8 sites fast on high-latency networks, prevent CSS/JS aggregation from taking down sites and use HTTP GET for AJAX requests, point 3:

+++ b/core/lib/Drupal/Core/Render/MainContent/AjaxRenderer.php
@@ -84,9 +85,7 @@ public function renderResponse(array $main_content, Request $request, RouteMatch
   protected function drupalRenderRoot(&$elements) {
-    $output = drupal_render_root($elements);
-    drupal_process_attached($elements);
-    return $output;
+    return drupal_render_root($elements);
   }

Follow-up, but this should have the renderer injected or not?