The "by Marty2081, anon: Fixed output of entity title." commit adds double encoding of a node title with an & in it. The node title shows correctly in the Javascript popup and autocomplete list.

Besluitenlijst college van burgemeester en wethouders (B&W)

Reverting the patch fixes it, but I guess this is related to the latest security issue?

CommentFileSizeAuthor
#7 linkit-adds-double-character-encoding-2406555-7-do-not-test.patch2.75 KBMrHaroldA
#5 linkit-thumbnails.jpg39.75 KBgmclelland
#3 linkit-adds-double-character-encoding-2406555-3.diff1.17 KBTess Bakker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

  • anon committed abf895c on 7.x-3.x 
    Issue #2406555 by anon: Linkit adds double character encoding when...
anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Status: Active » Fixed

Commited a fix to 3.x

Tess Bakker’s picture

Tess Bakker
they/them
Primary language Dutch
CreditAttribution: Tess Bakker commented
Version: 7.x-3.x-dev » 7.x-2.x-dev
Status: Fixed » Needs review
FileSize
linkit-adds-double-character-encoding-2406555-3.diff1.17 KB

Here is de 7.x-2.x patch for version 7.x-2.7

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented

Thanks, forgot that this was in issue in 7.2.

I'll patch it later.

gmclelland’s picture

gmclelland CreditAttribution: gmclelland commented
FileSize
linkit-thumbnails.jpg39.75 KB

It looks like this commit causes the linkit thumbnails to display the thumbnail's html instead of the thumbnail itself in the linkit search results dropdown.

Any ideas on how to fix it?

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented

No idea right now, sorry.

The main problem was that the description was open to XSS which is now fixed but this is a side effect of that.

MrHaroldA’s picture

MrHaroldA CreditAttribution: MrHaroldA commented
FileSize
linkit-adds-double-character-encoding-2406555-7-do-not-test.patch2.75 KB

Attaching the 3.x patch for packaging in distributions ...

danbarron’s picture

danbarron CreditAttribution: danbarron commented

Adding a vote to getting this fixed. We have a big site rollout happening at the end of the year and the content editors really need to see the thumbnails.

gmclelland’s picture

gmclelland CreditAttribution: gmclelland commented

@MrHaroldA - fyi...The patch in #7 no longer applies

  • anon committed 0288f36 on 7.x-3.x 
    Fixed #2406555 - Linkit adds double character encoding when inserting...
anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Needs review » Fixed

Committed a fix to 7.x-3,x

gmclelland’s picture

gmclelland CreditAttribution: gmclelland commented

Thanks @anon, that fix worked for me. I'm glad to have image previews back.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.