Problem/Motivation

A change was committed in #2348875: Improving our dump files which made the test results a little harder to interpret. See, https://www.drupal.org/node/2348875#comment-9506193

Proposed resolution

Simply add back the message on the assertion.

Remaining tasks

Write patch.

User interface changes

n/a

API changes

n/a

CommentFileSizeAuthor
#3 2406377-3.patch1.28 KBbenjy
#2 2406377-2.patch875 bytesbenjy
#1 2406377-1.patch876 bytesbenjy

Comments

benjy’s picture

benjy commented
Status: Active » Needs review
StatusFileSize
new 2406377-1.patch876 bytes

Added test back as requested.

benjy’s picture

benjy commented
StatusFileSize
new 2406377-2.patch875 bytes

Again.

benjy’s picture

benjy commented
Title: Improve assertion message in MigrateFieldTest » Remove unnecessary $field_storage->status assertions from MigrateFieldTest
StatusFileSize
new 2406377-3.patch1.28 KB

Discussed in IRC that a disabled $field_storage doesn't make much sense, removing the two assertions.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Good catch. Migrate is not frozen during beta, and this is a nice clean-up.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a6c29cb and pushed to 8.0.x. Thanks!

  • alexpott committed a6c29cb on 8.0.x 
    Issue #2406377 by benjy: Remove unnecessary $field_storage->status...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.