language_entity_field_access() doesn't work if $items isn't present

Untested.

Aw.

Yeah, I think we don't need more than that for tests. Maybe add add an assertion for the expected return value as well?

Based on what @plach said (the language field never being a configurable field), what I did is pretty useless. I would suggest we go back to my initial patch that I never uploaded, that simply moved all that logic inside an if ($items), and adds a comment that if we have no items, then we can't decide if it is visible or not, because we do not have enough information to figure that out?

+++ b/core/modules/language/language.module
@@ -511,11 +511,21 @@ function language_field_info_alter(&$info) {
-  $langcode_key = $items->getEntity()->getEntityType()->getKey('langcode');
-  if ($field_definition->getName() == $langcode_key) {
-    $entity = $items->getEntity();
-    $config = ContentLanguageSettings::loadByEntityTypeBundle($entity->getEntityTypeId(), $entity->bundle());
-    return AccessResult::forbiddenIf(!$config->isLanguageAlterable());
+  // Only allow access to a langcode field if the entity it is attached to is
+  // configured to have an alterable language.
+  // Without items we can not decide whether or not to allow access.
+  if ($items) {
+    // Check if we are dealing with a langcode field.
+    $entity_type = \Drupal::entityManager()->getDefinition($field_definition->getTargetEntityTypeId());
+    if ($field_definition->getName() == $entity_type->getKey('langcode')) {
+      // Fall back to neutral if we do not have a bundle.
+      $bundle = $items->getEntity()->bundle();
+      if ($bundle) {
+        // Grant access depending on whether the entity language can be altered.
+        $config = ContentLanguageSettings::loadByEntityTypeBundle($entity_type->id(), $bundle);
+        return AccessResult::forbiddenIf(!$config->isLanguageAlterable());
+      }
+    }

The conditional bundle part is no longer needed, you can use the original code instead now.

Filter by username returned the right amount.	Other	UserAdminTest.php	69	Drupal\user\Tests\UserAdminTest->testUserAdmin()

Unrelated random fail?

In general, I would disagree with #23, because $items is optional but in this case, we have no choice but to rely on it anyway. And it was the old implementation. RTBC +1.