When the Google Calendar event is openend in the same window, and the user is logged in with its google account, it is not efficient to return to the site. The browser will navigate the user to its own agenda first, so the user has to hit the "back" key twice to return to the site. Therefor it would be very useful to provide an option/setting in de module for opening the Google Calendar event in a new window/tab.

CommentFileSizeAuthor
#12 agenda-open-events-in-new-tab-2404531-12.patch2.1 KBalqahtani
#10 agenda-open-events-in-new-tab-2404531-9.patch2.1 KBalqahtani
#8 agenda-open-events-in-new-tab-2404531-8.patch747 bytesalqahtani
#4 Screen Shot 2015-01-14 at 12.43.55 PM.png38.77 KBalqahtani
#4 agenda-open-events-in-new-tab-2404531-4.patch2.13 KBalqahtani

Comments

wessenoort’s picture

wessenoort commented
Title: Open link to new window or tab » Open link for agenda item in new window or tab
wessenoort’s picture

wessenoort commented
Title: Open link for agenda item in new window or tab » Open link for Google Calendar event in new window or tab
Issue summary: View changes
wessenoort’s picture

wessenoort commented
Title: Open link for Google Calendar event in new window or tab » Open Google Calendar event in new window or tab
Issue summary: View changes
alqahtani’s picture

alqahtani commented
Status: Active » Needs review
StatusFileSize
new agenda-open-events-in-new-tab-2404531-4.patch2.13 KB
new Screen Shot 2015-01-14 at 12.43.55 PM.png38.77 KB

This patch is adding a "Open in new tab" checkbox in "agenda/%id/configure" right after "Calendar link text" textfield

Status: Needs review » Needs work

The last submitted patch, 4: agenda-open-events-in-new-tab-2404531-4.patch, failed testing.

alqahtani queued 4: agenda-open-events-in-new-tab-2404531-4.patch for re-testing.

The last submitted patch, 4: agenda-open-events-in-new-tab-2404531-4.patch, failed testing.

alqahtani’s picture

alqahtani commented
StatusFileSize
new agenda-open-events-in-new-tab-2404531-8.patch747 bytes

I don't know why that patch keep failing test. This is another patch that doesn't change much. It'll make events links always open in new tab. I hope it'll pass the test :)

alqahtani’s picture

alqahtani commented
alqahtani’s picture

alqahtani commented
Status: Needs work » Needs review
StatusFileSize
new agenda-open-events-in-new-tab-2404531-9.patch2.1 KB

I revised patch in #4 and it failed due to a trailing whitespace. this is the fixed patch.

Status: Needs review » Needs work

The last submitted patch, 10: agenda-open-events-in-new-tab-2404531-9.patch, failed testing.

alqahtani’s picture

alqahtani commented
Status: Needs work » Needs review
StatusFileSize
new agenda-open-events-in-new-tab-2404531-12.patch2.1 KB

Status: Needs review » Needs work

The last submitted patch, 12: agenda-open-events-in-new-tab-2404531-12.patch, failed testing.