Closed (fixed)
Project:
Project
Version:
7.x-2.x-dev
Component:
Usage statistics
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Jan 2015 at 21:04 UTC
Updated:
2 Nov 2015 at 18:54 UTC
Jump to comment: Most recent
Comments
Comment #1
drummI think http://cgit.drupalcode.org/publication_date/tree/publication_date.info needs
version = "7.x-2.x-dev"Otherwise, there is no way for Drupal to know the version when the module is run directly from Git.
In the tarball, there is
version = "7.x-2.1+11-dev"I think that will be counted with 7.x-2.1.
Comment #2
jstollerSo, the .info file will have two version declarations? Is this documented anywhere? It seems like a bug to me. I would expect that 7.x-2.1+11-dev could be recognized as 7.x-2.x-dev. Or, if that's too difficult, then why wouldn't 7.x-2.1+11-dev be listed as its own version? It might mean a significant increase in the number of versions listed, but at least it would be accurate.
Comment #3
drummI double checked this, and it is indeed documented that I was wrong about including a version in the .info file as checked into Git, https://www.drupal.org/node/542202. (It is something core is okay with in D7 and lower, values further down in the file replace others.)
That said, update module needs some source of version information for Git checkouts. Either Git deploy module, or drush make doing its own .info file additions.
Comment #4
drummI do see a likely bug in our usage stat processing. http://cgit.drupalcode.org/project/tree/usage/project_usage.drush.inc#n270 looks like it uses the version from the URL directly, so those versions would not be counted.
If
$qdata['version']matches the7.x-1.0+10-devformat, it should be rewritten to7.x-1.x-dev.Comment #5
jstollerFor what it's worth, the module on my site was installed via drush and I've confirmed that .info contains the information added by the Drupal.org packaging script, including the version string.
Comment #6
jstollerI was poking around, and found a number of other modules on D.O. that have dev releases represented in their usage statistics and I don't see anything different about their .info files. What's the difference between my Publication Date module and, say, the Display Suite module?
Comment #7
MixologicThis was fixed as a part of larger usage stat processing updates
http://cgit.drupalcode.org/infrastructure/tree/stats/fastlyusagestatpars...