In #985758: Implement Features hooks to export and import configurations some hard and much appreciated work is being done to make the Features-integration for this module feature-complete (no pun intended). However, in the current stable release, the Features-intergation is incomplete; it is only possible to export password policies, but importing them is not. This actually leads to some confusing and fairly serious problems; for example, reverting the Feature containing a password policy will not update/change the policy back to the one in the Feature, but will in fact remove the policy altogether. I propose that as a stop-gap measure, the exportability should be removed while the Features-integration is being worked on in #985758: Implement Features hooks to export and import configurations.
If it is agreed this is a good way forward for the short term, I would be happy to put in the leg work to provide a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | password_policy-remove_ctools_export-2401787-6.patch | 2.81 KB | aohrvetpv |
| #3 | password_policy-remove_ctools_export-2401787-3.patch | 2.8 KB | aohrvetpv |
Comments
Comment #1
eelkeblokComment #2
aohrvetpv commentedSeems like a good idea to me. It could save Password Policy users from trouble due to exporting configuration with the expectation they will be able to later import it.
Even if the export functionality is removed, some Password Policy users may have already exported configuration that they will later want to import, right, so I think it is desirable to eventually get the import functionality working and released in 7.x-1.x.
Comment #3
aohrvetpv commentedThis patch is a partial revert of http://drupalcode.org/project/password_policy.git/commit/e389e6a. It removes from the array returned by
hook_schema()the parts that tell Ctools about what is exportable. After applying it,drush ctools-export-infono longer shows objects to export.I left the changes to the database made to accommodate Ctools export. There seems to be no downside to leaving them, and it would take some work to remove them. We may need the changes once Ctools import/export is fully functional.
I have never used Ctools export or Features before, so this patch needs review. I am not really sure how this relates to Features, as I did not see anything in the Features UI pertaining to Password Policy or Ctools exports.
Comment #5
aohrvetpv commentedLet's go ahead with the change and see if it causes any problems.
Comment #6
aohrvetpv commentedComment #8
aohrvetpv commented