Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kim.pepper’s picture

Status: Active » Needs review
FileSize
103.42 KB

Updated composer.json to require 2.3.* and ran composer update zendframework/zend-feed zendframework/zend-stdlib zendframework/zend-escaper

Status: Needs review » Needs work

The last submitted patch, 1: 2401113-zend-feed-1.patch, failed testing.

kim.pepper’s picture

+++ b/core/vendor/zendframework/zend-feed/Zend/Feed/Reader/Reader.php
@@ -299,6 +298,11 @@ public static function importRemoteFeed($uri, Http\ClientInterface $client)
     public static function importString($string)
     {
+        $trimmed = trim($string);
+        if (!is_string($string) || empty($trimmed)) {
+            throw new Exception\InvalidArgumentException('Only non empty strings are allowed as input');
+        }

This change seems to be the cause of the fails. Is it possible we aren't passing in a string?

kim.pepper’s picture

Status: Needs work » Needs review
FileSize
104.15 KB
751 bytes

Looks like there was a call to getBody(TRUE) that was missed in the update to Guzzle 5.See #2348365: Update to Guzzle 5 for more info.

kim.pepper’s picture

Priority: Normal » Critical

Updating to critical as the parent issue is critical.

kim.pepper’s picture

Added a follow up for converting all instances of getBody(TRUE) to (string) getBody() #2401159: Convert instances of Guzzle getBody(TRUE)

larowlan’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
182.53 KB

Manually tests fine

larowlan’s picture

+++ b/composer.lock
@@ -2575,6 +2593,7 @@
+    "prefer-lowest": false,

This is a new composer property - all good

webchick’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Sorry, this conflicts with #2401109: Update EasyRdf to latest stable. so needs a quick reroll. Tried a --3way merge but it still couldn't quite do it. I wanted to commit this one first, since I can see that it's harder to re-roll, but testbot wasn't back yet.

kim.pepper’s picture

Status: Needs work » Needs review
FileSize
103.5 KB

Re-ran composer update zendframework/zend-feed zendframework/zend-stdlib zendframework/zend-escaper

larowlan’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs reroll

Ran the commands locally myself and there were no unexpected differences. Committed d7e814a and pushed to 8.0.x. Thanks!

  • alexpott committed d7e814a on 8.0.x
    Issue #2401113 by kim.pepper, larowlan: Update Zend Feed to latest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.