Problem/Motivation

user.views.schema.yml contains a duplicate for one entry
Found whilst working on #1920902: Add a Drupal Yaml wrapper so we can default to PECL Yaml component if it is available

Proposed resolution

Fix

Remaining tasks

Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#4 2400771-3-after.png87.48 KBidebr
#3 user-schema.2.patch611 byteslarowlan
user-views-schema.patch705 byteslarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Nice catch thanks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/user/config/schema/user.views.schema.yml
@@ -68,17 +68,13 @@ views_field_user:
 views.field.user_language:
-  type: views_field
+  type: views_field_user
   label: 'User language'
   mapping:
     link_to_node:
       type: boolean
       label: 'Link this field to its user'

Afaics this is the one that should be removed. Manual testing revealed no option to link to user and link_to_node is a strange option for a user :)

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
user-schema.2.patch611 bytes
idebr’s picture

idebr CreditAttribution: idebr commented
Status: Needs review » Reviewed & tested by the community
FileSize
2400771-3-after.png87.48 KB

I tested the patch on Simplytest and I can confirm the 'Link to user' is still there. The 'Link to edit user' is currently broken, but this appears to be unrelated to this patch and I have created a new issue at #2401265: Views field 'Link to edit user' has a duplicate destination parameter, returns WSOD.

Screenshot after:

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed bb7adeb and pushed to 8.0.x. Thanks!

@idebr the old configuration was implying there was the ability to link the langcode to the user - there isn't :)

  • alexpott committed bb7adeb on 8.0.x 
    Issue #2400771 by larowlan: Duplicate entry for user views data schema

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.