How to reproduce:
* Create a relationship with optional required context
* Leave that context empty

Relationship will never be called then.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geek-merlin’s picture

Status: Active » Needs review
FileSize
1.28 KB

Patch flying in that fixes this for me.

geek-merlin’s picture

Title: Relationship handling broken with optional required context » Relationship silently left out if it has optional required context
Priority: Normal » Major

This makes #1588212: Add "optional" checkbox to require contexts within mini panels break existing sites so setting major and improving title.

sylus’s picture

Status: Needs review » Reviewed & tested by the community

Working well for me too too bad didn't get this to RTBC before release.

geek-merlin’s picture

It looks like there is another issue with similar but not same code: #2341363: Relationship with optional contexts does not work
Didn't check if it's a dup.

rivimey’s picture

Patch in #1 applies cleanly to 7.x-1.x

Patch passes ctools tests run locally. If @axel.rutz is watching still it would be good to see a mod to the patch that includes a bit more comment in the code; it is not obvious (to me at least) what is happening.

It would appear to me that this patch has at least two other related issues, and one of them (https://www.drupal.org/node/1588212) has in #31 (https://www.drupal.org/node/1588212#comment-10538470) been determined to be closed.

Could someone please clarify whether the problem here is fixed or not?

In the meantime, this looks like a duplicate.

DamienMcKenna’s picture

It wasn't committed to 1.11.

MustangGB’s picture

Status: Postponed (maintainer needs more info) » Needs review
joelpittet’s picture

Status: Needs review » Fixed

@geek-merlin Thanks for the patch, I've committed it to the latest dev. Minor change on commit I merged the elseif at the end.

  • joelpittet committed 4f4c425 on 7.x-1.x authored by geek-merlin
    Issue #2399313 by geek-merlin, sylus, rivimey, DamienMcKenna, MustangGB...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.