comment_form_field_ui_field_storage_edit_form_alter() no longer working

By working on this issue, i found another "issue" with the latest 8.0.x.
I'm not sure, if i misconfigured my page after installation - but i don't get any Comment types - even if i create new types on Structure > Comment Types.

Attached you find a patch setting cardinality_container back to be not visible as they were before.

SteffenR

+++ b/core/modules/comment/comment.module
@@ -351,8 +351,8 @@ function comment_form_field_ui_field_storage_edit_form_alter(&$form, FormStateIn
-    $form['field']['cardinality_container']['cardinality']['#options'] = array(1 => 1);
-    $form['field']['cardinality_container']['#access'] = FALSE;
+    $form['field_storage']['cardinality_container']['cardinality']['#options'] = array(1 => 1);
+    $form['field_storage']['cardinality_container']['#access'] = FALSE;

not sure why we change #options instead of changing #default_value?

Would it make sense to also verify that the created field has cardinality 1, or are we already doing this?

Thanks, RTBC if green :)

Hello, I don't get any Comment types when I apply the last patch, this behavior is well?

That's a separate issue. You're trying to add a comment field to users, you need to create a comment type for that first.

@Berdir You are right!

Is there really no way a field item can declare it only supports cardinality one? I was looking earlier, and it's certainly not evident how it would work.

Committed 7a52a88 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the summary.