After #2375673: Split Bartik's CSS into SMACSS style components comment arrow image and required image on header area not showing up. Reason is that they are pointing to wrong folder.

Remaining tasks:
1. Write a patch
2. Insert screenshots
3. Review manually
4. RTBC

CommentFileSizeAuthor
#13 2398531-13.patch1.3 KBrpayanm
#13 2398531-interdiff.txt523 bytesrpayanm
#6 comment-arrow-missing-2398531-5.patch812 bytesDickJohnson
#2 bartik-comment-arrow-missing-3.png52.39 KBDickJohnson
#2 comment-arrow-missing-2398531-2.patch812 bytesDickJohnson
bartik-comment-border-2.png52.55 KBDickJohnson
bartik-comment-border.png100.45 KBDickJohnson

Comments

DickJohnson’s picture

DickJohnson commented
Issue summary: View changes
DickJohnson’s picture

DickJohnson commented
StatusFileSize
new comment-arrow-missing-2398531-2.patch812 bytes
new bartik-comment-arrow-missing-3.png52.39 KB

While playing around with it, I noticed that after CSS -> SMACSS split has been commited, the comment arrow has been pointing to wrong direction.

Patch and screenshot as attachments.

Comment arrow added back.

DickJohnson’s picture

DickJohnson commented
Status: Active » Needs review
DickJohnson’s picture

DickJohnson commented
Title: Comment border is breaking up while commenting as logged in user » Comment arrow is missing while commenting as logged in user

Status: Needs review » Needs work

The last submitted patch, 2: comment-arrow-missing-2398531-2.patch, failed testing.

DickJohnson’s picture

DickJohnson commented
Status: Needs work » Needs review
StatusFileSize
new comment-arrow-missing-2398531-5.patch812 bytes

No idea why it failed, so tried to create new patch.

Status: Needs review » Needs work

The last submitted patch, 6: comment-arrow-missing-2398531-5.patch, failed testing.

DickJohnson’s picture

DickJohnson commented
Version: 8.0.0-beta4 » 8.0.x-dev

Ok, so I accidentally chose wrong version.

Status: Needs work » Needs review

DickJohnson queued 6: comment-arrow-missing-2398531-5.patch for re-testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Not sure how we could write tests for this

DickJohnson’s picture

DickJohnson commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

Can we also fix 

.region-header .form-required:after {
  background-image: url(../images/required.svg);
}

whilst we are it since this was all broken by #2375673: Split Bartik's CSS into SMACSS style components - The issue will need a new summary and title.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 2398531-interdiff.txt523 bytes
new 2398531-13.patch1.3 KB
DickJohnson’s picture

DickJohnson commented
Title: Comment arrow is missing while commenting as logged in user » Some images not showing after SMACSS split
Issue summary: View changes
DickJohnson’s picture

DickJohnson commented
Status: Needs review » Reviewed & tested by the community

Checked the patch and it's fixing the issue mentioned in #13 perfectly.

DickJohnson’s picture

DickJohnson commented
Title: Some images not showing after SMACSS split » Some images not showing up after SMACSS split
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs issue summary update

This issue is a normal bug fix, and doesn't include any disruptive changes, and is markup change is permitted as per https://www.drupal.org/core/beta-changes. Committed 1849e5c and pushed to 8.0.x. Thanks!

  • alexpott committed 1849e5c on 8.0.x 
    Issue #2398531 by DickJohnson, rpayanm: Some images not showing up after...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.