Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After #2375673: Split Bartik's CSS into SMACSS style components comment arrow image and required image on header area not showing up. Reason is that they are pointing to wrong folder.
Remaining tasks:
1. Write a patch
2. Insert screenshots
3. Review manually
4. RTBC
Comment | File | Size | Author |
---|---|---|---|
#13 | 2398531-13.patch | 1.3 KB | rpayanm |
#13 | 2398531-interdiff.txt | 523 bytes | rpayanm |
Comments
Comment #1
DickJohnson CreditAttribution: DickJohnson commentedComment #2
DickJohnson CreditAttribution: DickJohnson commentedWhile playing around with it, I noticed that after CSS -> SMACSS split has been commited, the comment arrow has been pointing to wrong direction.
Patch and screenshot as attachments.
Comment #3
DickJohnson CreditAttribution: DickJohnson commentedComment #4
DickJohnson CreditAttribution: DickJohnson commentedComment #6
DickJohnson CreditAttribution: DickJohnson commentedNo idea why it failed, so tried to create new patch.
Comment #8
DickJohnson CreditAttribution: DickJohnson commentedOk, so I accidentally chose wrong version.
Comment #10
larowlanNot sure how we could write tests for this
Comment #11
DickJohnson CreditAttribution: DickJohnson commentedComment #12
alexpottCan we also fix
whilst we are it since this was all broken by #2375673: Split Bartik's CSS into SMACSS style components - The issue will need a new summary and title.
Comment #13
rpayanmComment #14
DickJohnson CreditAttribution: DickJohnson commentedComment #15
DickJohnson CreditAttribution: DickJohnson commentedChecked the patch and it's fixing the issue mentioned in #13 perfectly.
Comment #16
DickJohnson CreditAttribution: DickJohnson commentedComment #17
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, and is markup change is permitted as per https://www.drupal.org/core/beta-changes. Committed 1849e5c and pushed to 8.0.x. Thanks!