Need to add class 'chosen-rtl' to the select if the direction is RTL

CommentFileSizeAuthor
#16 right_to_left_support-2398291-16.patch623 bytesmr.york
#14 right_to_left_support-2398291-14.patch1.24 KBmr.york
#13 right_to_left_support-2398291-13.patch1.24 KBmr.york
#10 right_to_left_support-2398291-10.patch836 bytesmr.york
#1 chosen_right_to_left_support-2398291-1.patch872 bytesm.abdulqader

Comments

m.abdulqader’s picture

m.abdulqader commented
StatusFileSize
new chosen_right_to_left_support-2398291-1.patch872 bytes

I added the class as mention in the library page.
http://harvesthq.github.io/chosen/#right-to-left-support

m.abdulqader’s picture

m.abdulqader commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: chosen_right_to_left_support-2398291-1.patch, failed testing.

m.abdulqader’s picture

m.abdulqader commented
Version: 7.x-1.0 » 7.x-2.x-dev
Status: Needs work » Needs review

m.abdulqader queued 1: chosen_right_to_left_support-2398291-1.patch for re-testing.

sibany’s picture

sibany commented

Tested on dev and it works!, also work's on Version: 7.x-2.0-beta4!

Thanks

m.abdulqader’s picture

m.abdulqader commented

Its work for me with the new version.
Nice if it commited.

m.abdulqader’s picture

m.abdulqader commented
Status: Needs review » Reviewed & tested by the community
nagy.balint’s picture

nagy.balint commented

Going to review it soon.

mr.york’s picture

mr.york commented
StatusFileSize
new right_to_left_support-2398291-10.patch836 bytes

Tested and reviewed this patch. Works good for me.
Reroll the patch.

nagy.balint’s picture

nagy.balint commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed.

mr.york’s picture

mr.york commented
StatusFileSize
new right_to_left_support-2398291-13.patch1.24 KB

Attached d8 port.

mr.york’s picture

mr.york commented
StatusFileSize
new right_to_left_support-2398291-14.patch1.24 KB

Add coding standard fix.

  • nagy.balint committed a5ab1e5 on 8.x-2.x authored by mr.york 
    Issue #2398291 by mr.york, m.abdulqader: Right to Left Support
mr.york’s picture

mr.york commented
StatusFileSize
new right_to_left_support-2398291-16.patch623 bytes

Only coding standard fix.

nagy.balint’s picture

nagy.balint commented
Status: Patch (to be ported) » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.