Problem/Motivation

AccessRoleTest can fail if the generated role id comes before "anonymous" in the alphabet because the roles are sorted alphabetically.

Proposed resolution

Prefix it with something?

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 access-role-test-random-fail-2398259-1-fail.patch694 bytesberdir
#1 access-role-test-random-fail-2398259-1-proof.patch1.55 KBberdir
#1 access-role-test-random-fail-2398259-1.patch894 bytesberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new access-role-test-random-fail-2398259-1.patch894 bytes
new access-role-test-random-fail-2398259-1-proof.patch1.55 KB
new access-role-test-random-fail-2398259-1-fail.patch694 bytes

- fail shows when fails.
- proof is the forced fail with the fix
- and the last patch is the one to commit.

Status: Needs review » Needs work

The last submitted patch, 1: access-role-test-random-fail-2398259-1-fail.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Meant to upload the in the opposite order..

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Makes sense

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 3359738 and pushed to 8.0.x. Thanks!

  • alexpott committed 3359738 on 8.0.x 
    Issue #2398259 by Berdir: Random test fail in AccessRoleTest
dawehner’s picture

dawehner
Primary language German
commented

Did we considered on this issue to use something else than assertIdentical here?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.