All of our javascript should pass eslint testing - currently it does not. This fails were introduced by #1963340: Change field UI so that adding a field is a separate task. Seems like #2393391: JS Follow-up to #1963340 did not catch everything :)

 8.0.x  alex: ~/dev/drupal > eslint ./

core/modules/field_ui/field_ui.js
  31:28  error  Expected '!==' and instead saw '!='  eqeqeq
  41:20  error  Expected '!==' and instead saw '!='  eqeqeq

✖ 2 problems
CommentFileSizeAuthor
d8-field-ui-js-standards.patch938 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

We use for Drupal ESLint testing for javascript. The rules for the use of === and !== is that it is good practice to use them instead of their regular counterparts == and !=.

It all looks good to me and it is a very simple patch, so RTBC for me.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Related issues: +#2389515: Update ESLint rules

This is included in #2389515: Update ESLint rules. I'd rather get that other issue reviewed and committed.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Well, it's been over a week and that issue's still outstanding and this one's tiny and ready to go, so...

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 6f23024 on 8.0.x 
    Issue #2397681 by alexpott: field_ui.js fails eslint validation

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.