Drupal.formatPlural does not work

Drupal.formatString converts args['@count'] to string on which the strict equality check fails.
No brainer. Ready to commit.

We only use strict equals, if there is a conversion somewhere we either remove it or check for the appropriate type.

Drupal.formatString alters the passed args object by applying sanitizers. For strict equality we need to keep the args intact.

@Chi, sorry should have explained more. We have coding standards for javascript, we also have an eslint configuration. Our configuration doesn't allow "sloppy equals", there is no reason to relax our standards for this.

Since we know Drupal.t() will transform all args to string, I would rather do if (args['@count'] !== '1'), add a comment before to explain it comes from Drupal.t() escaping the value if you feel an explanation is needed.

Making a new object with the arg values is a little dangerous, after calling Drupal.formatString I would expect everything to be escaped, here we end up with unsanitized values in the original arg object, and the safe values can't be accessed outside formatString.

after calling Drupal.formatString I would expect everything to be escaped

You shouldn't expect that. Drupal.formatString is not supposed to alter the given args. There should be another method for it, something like Drupal.sanitizeArgs.

Yeah you're right, that was a poor attempt at justifying a one line patch instead of a proper solution.

Can you just rename newArgs into processedArgs, or something a bit more explicit than 'new'?

Renamed to processedArgs

It works now, thanks!

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 7f5bc4e and pushed to 8.0.x. Thanks!

Tagging in retrospect.